Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1357693003: Returning scoped_ptr<> instead of raw pointer in WebSocket::CreateWebSocket (Closed)

Created:
5 years, 3 months ago by Paritosh Kumar
Modified:
5 years, 3 months ago
Reviewers:
eroman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Returning scoped_ptr<> instead of raw pointer in WebSocket::CreateWebSocket BUG=479898 Committed: https://crrev.com/cde3173232ce3c218b38981c3f5d2494d6ceb513 Cr-Commit-Position: refs/heads/master@{#350106}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M net/server/http_server.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/server/web_socket.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M net/server/web_socket.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paritosh Kumar
Please have a look.
5 years, 3 months ago (2015-09-21 14:03:37 UTC) #2
eroman
lgtm
5 years, 3 months ago (2015-09-21 17:19:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357693003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357693003/20001
5 years, 3 months ago (2015-09-22 02:57:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-22 04:28:24 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 04:29:11 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cde3173232ce3c218b38981c3f5d2494d6ceb513
Cr-Commit-Position: refs/heads/master@{#350106}

Powered by Google App Engine
This is Rietveld 408576698