Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1357573002: Reland of zone: gbm: Default use_system_minigbm=1 to mitigate build breaks (Closed)

Created:
5 years, 3 months ago by Pawel Osciak
Modified:
5 years, 3 months ago
Reviewers:
marcheu, dnicoara, spang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of zone: gbm: Default use_system_minigbm=1 to mitigate build breaks (patchset #1 id:1 of https://codereview.chromium.org/1357433003/ ) Reason for revert: UI does not come up on x86 with below errors: ERROR:gbm_device.cc(26)] Unable to initialize GBM for /dev/dri/card0: Invalid argument ERROR:drm_device_manager.cc(54)] Could not initialize DRM device for /dev/dri/card0 Revert seems to be fixing that. Original issue's description: > Revert of ozone: gbm: Default use_system_minigbm=1 to mitigate build breaks (patchset #3 id:40001 of https://codereview.chromium.org/1344263002/ ) > > Reason for revert: > This should work now. > > Original issue's description: > > ozone: gbm: Default use_system_minigbm=1 to mitigate build breaks > > > > The chrome-sdk needs to update with the flag to avoid breakage. > > This CL can be reverted when the chrome-sdk updates with the > > new use_system_minigbm setting in GYP_DEFINES. > > > > TBR=dnicoara (build break) > > NOTRY=true > > > > Committed: https://crrev.com/0e8f0106e7e01cee911dd2b34c263c01788e7186 > > Cr-Commit-Position: refs/heads/master@{#349041} > > TBR=dnicoara@chromium.org > > Committed: https://crrev.com/fcef2de97794abf899bb3efe78657355661c7b3d > Cr-Commit-Position: refs/heads/master@{#349450} TBR=dnicoara@chromium.org,spang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/minigbm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/minigbm/minigbm.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/ozone.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Pawel Osciak
Created Reland of zone: gbm: Default use_system_minigbm=1 to mitigate build breaks
5 years, 3 months ago (2015-09-18 02:23:14 UTC) #1
Pawel Osciak
5 years, 3 months ago (2015-09-18 03:57:36 UTC) #3
On 2015/09/18 02:23:14, Pawel Osciak wrote:
> Created Reland of zone: gbm: Default use_system_minigbm=1 to mitigate build
> breaks

Sorry for the commotion, looks like my GYP_DEFINES didn't update correctly yet,
hence the issue.

Powered by Google App Engine
This is Rietveld 408576698