Issue 135753006: cc: Delete ContextProvider::MakeGrContextCurrent.

Issue 135753006: cc: Delete ContextProvider::MakeGrContextCurrent. (Closed)

Created:
6 years, 11 months ago by alokp

Modified:
6 years, 11 months ago

Reviewers:
danakj, jamesr, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, viettrungluu+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, kalyank, darin (slow to review), piman+watch_chromium.org, cc-bugs_chromium.org, abarth-chromium, ben+mojo_chromium.org, danakj+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Delete ContextProvider::MakeGrContextCurrent. It is not necessary to explicitly make the GrContext current. The underlying GL context is automatically made current via a callback setup by all implementations of cc::ContextProvider. Ganesh calls this callback before issuing any GL command, which ensures the the appropriate GL context is current. BUG=334886 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245475

Patch Set 1 #

Total comments: 2

Patch Set 2 : deleted GR_GL_PER_GL_FUNC_CALLBACK guard #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -63 lines)			Patch
M	cc/output/context_provider.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/output/gl_renderer.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	cc/resources/raster_worker_pool.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	cc/test/test_context_provider.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/test/test_context_provider.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	cc/test/test_in_process_context_provider.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/test/test_in_process_context_provider.cc	View	1	2 chunks	+19 lines, -26 lines	0 comments	Download
M	content/common/gpu/client/context_provider_command_buffer.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/common/gpu/client/context_provider_command_buffer.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	mojo/examples/aura_demo/demo_context_factory.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/examples/compositor_app/compositor_host.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/common/gpu/context_provider_in_process.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/common/gpu/context_provider_in_process.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	webkit/common/gpu/grcontext_for_webgraphicscontext3d.cc	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/135753006/diff/1/cc/test/test_in_process_context_provider.cc File cc/test/test_in_process_context_provider.cc (right): https://codereview.chromium.org/135753006/diff/1/cc/test/test_in_process_context_provider.cc#newcode85 cc/test/test_in_process_context_provider.cc:85: #if GR_GL_PER_GL_FUNC_CALLBACK i've seen this #if guard in ...

6 years, 11 months ago (2014-01-16 19:31:07 UTC) #2

alokp

https://codereview.chromium.org/135753006/diff/1/cc/test/test_in_process_context_provider.cc File cc/test/test_in_process_context_provider.cc (right): https://codereview.chromium.org/135753006/diff/1/cc/test/test_in_process_context_provider.cc#newcode85 cc/test/test_in_process_context_provider.cc:85: #if GR_GL_PER_GL_FUNC_CALLBACK Good point. It will be better to ...

6 years, 11 months ago (2014-01-16 22:00:47 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/135753006/150001

6 years, 11 months ago (2014-01-16 22:03:58 UTC) #4

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=45190

6 years, 11 months ago (2014-01-16 22:23:43 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/135753006/150001

6 years, 11 months ago (2014-01-17 05:24:37 UTC) #8

Message was sent while issue was closed.

Change committed as 245475

Expand Messages | Collapse Messages