Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Side by Side Diff: Source/web/WebDevToolsAgentImpl.h

Issue 135753002: Update web classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/WebDataSourceImpl.h ('k') | Source/web/WebDevToolsFrontendImpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 class WebFrame; 58 class WebFrame;
59 class WebFrameImpl; 59 class WebFrameImpl;
60 class WebString; 60 class WebString;
61 class WebURLRequest; 61 class WebURLRequest;
62 class WebURLResponse; 62 class WebURLResponse;
63 class WebViewImpl; 63 class WebViewImpl;
64 struct WebMemoryUsageInfo; 64 struct WebMemoryUsageInfo;
65 struct WebURLError; 65 struct WebURLError;
66 struct WebDevToolsMessageData; 66 struct WebDevToolsMessageData;
67 67
68 class WebDevToolsAgentImpl : public WebDevToolsAgentPrivate, 68 class WebDevToolsAgentImpl FINAL :
69 public WebCore::InspectorClient, 69 public WebDevToolsAgentPrivate,
70 public WebCore::InspectorFrontendChannel, 70 public WebCore::InspectorClient,
71 public WebPageOverlay, 71 public WebCore::InspectorFrontendChannel,
72 private WebThread::TaskObserver { 72 public WebPageOverlay,
73 private WebThread::TaskObserver {
73 public: 74 public:
74 WebDevToolsAgentImpl(WebViewImpl* webViewImpl, WebDevToolsAgentClient* clien t); 75 WebDevToolsAgentImpl(WebViewImpl* webViewImpl, WebDevToolsAgentClient* clien t);
75 virtual ~WebDevToolsAgentImpl(); 76 virtual ~WebDevToolsAgentImpl();
76 77
77 // WebDevToolsAgentPrivate implementation. 78 // WebDevToolsAgentPrivate implementation.
78 virtual void didCreateScriptContext(WebFrameImpl*, int worldId); 79 virtual void didCreateScriptContext(WebFrameImpl*, int worldId) OVERRIDE;
79 virtual void webViewResized(const WebSize&); 80 virtual void webViewResized(const WebSize&) OVERRIDE;
80 virtual bool handleInputEvent(WebCore::Page*, const WebInputEvent&); 81 virtual bool handleInputEvent(WebCore::Page*, const WebInputEvent&) OVERRIDE ;
81 82
82 // WebDevToolsAgent implementation. 83 // WebDevToolsAgent implementation.
83 virtual void attach(); 84 virtual void attach() OVERRIDE;
84 virtual void reattach(const WebString& savedState); 85 virtual void reattach(const WebString& savedState) OVERRIDE;
85 virtual void detach(); 86 virtual void detach() OVERRIDE;
86 virtual void didNavigate(); 87 virtual void didNavigate() OVERRIDE;
87 virtual void didBeginFrame(int frameId); 88 virtual void didBeginFrame(int frameId) OVERRIDE;
88 virtual void didCancelFrame(); 89 virtual void didCancelFrame() OVERRIDE;
89 virtual void willComposite(); 90 virtual void willComposite() OVERRIDE;
90 virtual void didComposite(); 91 virtual void didComposite() OVERRIDE;
91 virtual void dispatchOnInspectorBackend(const WebString& message); 92 virtual void dispatchOnInspectorBackend(const WebString& message) OVERRIDE;
92 virtual void inspectElementAt(const WebPoint& point); 93 virtual void inspectElementAt(const WebPoint&) OVERRIDE;
93 virtual void evaluateInWebInspector(long callId, const WebString& script); 94 virtual void evaluateInWebInspector(long callId, const WebString& script) OV ERRIDE;
94 virtual void setProcessId(long); 95 virtual void setProcessId(long) OVERRIDE;
95 virtual void setLayerTreeId(int); 96 virtual void setLayerTreeId(int) OVERRIDE;
96 // FIXME: remove it once the client side stops firing these. 97 // FIXME: remove it once the client side stops firing these.
97 virtual void processGPUEvent(double timestamp, int phase, bool foreign) OVER RIDE; 98 virtual void processGPUEvent(double timestamp, int phase, bool foreign) OVER RIDE;
98 virtual void processGPUEvent(const GPUEvent&) OVERRIDE; 99 virtual void processGPUEvent(const GPUEvent&) OVERRIDE;
99 100
100 // InspectorClient implementation. 101 // InspectorClient implementation.
101 virtual void highlight(); 102 virtual void highlight() OVERRIDE;
102 virtual void hideHighlight(); 103 virtual void hideHighlight() OVERRIDE;
103 virtual void updateInspectorStateCookie(const WTF::String&); 104 virtual void updateInspectorStateCookie(const WTF::String&) OVERRIDE;
104 virtual bool sendMessageToFrontend(const WTF::String&); 105 virtual bool sendMessageToFrontend(const WTF::String&) OVERRIDE;
105 106
106 virtual void clearBrowserCache(); 107 virtual void clearBrowserCache() OVERRIDE;
107 virtual void clearBrowserCookies(); 108 virtual void clearBrowserCookies() OVERRIDE;
108 109
109 virtual void overrideDeviceMetrics(int width, int height, float deviceScaleF actor, bool emulateViewport, bool fitWindow); 110 virtual void overrideDeviceMetrics(int width, int height, float deviceScaleF actor, bool emulateViewport, bool fitWindow) OVERRIDE;
110 111
111 virtual void getAllocatedObjects(HashSet<const void*>&); 112 virtual void getAllocatedObjects(HashSet<const void*>&) OVERRIDE;
112 virtual void dumpUncountedAllocatedObjects(const HashMap<const void*, size_t >&); 113 virtual void dumpUncountedAllocatedObjects(const HashMap<const void*, size_t >&) OVERRIDE;
113 virtual void setTraceEventCallback(TraceEventCallback); 114 virtual void setTraceEventCallback(TraceEventCallback) OVERRIDE;
114 virtual void startGPUEventsRecording() OVERRIDE; 115 virtual void startGPUEventsRecording() OVERRIDE;
115 virtual void stopGPUEventsRecording() OVERRIDE; 116 virtual void stopGPUEventsRecording() OVERRIDE;
116 117
117 virtual void dispatchKeyEvent(const WebCore::PlatformKeyboardEvent&); 118 virtual void dispatchKeyEvent(const WebCore::PlatformKeyboardEvent&) OVERRID E;
118 virtual void dispatchMouseEvent(const WebCore::PlatformMouseEvent&); 119 virtual void dispatchMouseEvent(const WebCore::PlatformMouseEvent&) OVERRIDE ;
119 120
120 // WebPageOverlay 121 // WebPageOverlay
121 virtual void paintPageOverlay(WebCanvas*); 122 virtual void paintPageOverlay(WebCanvas*) OVERRIDE;
122 123
123 private: 124 private:
124 // WebThread::TaskObserver 125 // WebThread::TaskObserver
125 virtual void willProcessTask(); 126 virtual void willProcessTask() OVERRIDE;
126 virtual void didProcessTask(); 127 virtual void didProcessTask() OVERRIDE;
127 128
128 void enableViewportEmulation(); 129 void enableViewportEmulation();
129 void disableViewportEmulation(); 130 void disableViewportEmulation();
130 131
131 WebCore::InspectorController* inspectorController(); 132 WebCore::InspectorController* inspectorController();
132 WebCore::Frame* mainFrame(); 133 WebCore::Frame* mainFrame();
133 134
134 int m_hostId; 135 int m_hostId;
135 WebDevToolsAgentClient* m_client; 136 WebDevToolsAgentClient* m_client;
136 WebViewImpl* m_webViewImpl; 137 WebViewImpl* m_webViewImpl;
137 bool m_attached; 138 bool m_attached;
138 bool m_generatingEvent; 139 bool m_generatingEvent;
139 bool m_deviceMetricsEnabled; 140 bool m_deviceMetricsEnabled;
140 bool m_emulateViewportEnabled; 141 bool m_emulateViewportEnabled;
141 bool m_originalViewportEnabled; 142 bool m_originalViewportEnabled;
142 bool m_isOverlayScrollbarsEnabled; 143 bool m_isOverlayScrollbarsEnabled;
143 }; 144 };
144 145
145 } // namespace blink 146 } // namespace blink
146 147
147 #endif 148 #endif
OLDNEW
« no previous file with comments | « Source/web/WebDataSourceImpl.h ('k') | Source/web/WebDevToolsFrontendImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698