Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: Source/web/PopupMenuChromium.h

Issue 135753002: Update web classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/PopupListBox.h ('k') | Source/web/PrerendererClientImpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2008, 2009, Google Inc. All rights reserved. 2 * Copyright (c) 2008, 2009, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 25 matching lines...) Expand all
36 36
37 namespace WebCore { 37 namespace WebCore {
38 38
39 class Frame; 39 class Frame;
40 class FrameView; 40 class FrameView;
41 class IntRect; 41 class IntRect;
42 class PopupContainer; 42 class PopupContainer;
43 struct PopupItem; 43 struct PopupItem;
44 class PopupMenuClient; 44 class PopupMenuClient;
45 45
46 class PopupMenuChromium : public PopupMenu { 46 class PopupMenuChromium FINAL : public PopupMenu {
47 public: 47 public:
48 PopupMenuChromium(Frame&, PopupMenuClient*); 48 PopupMenuChromium(Frame&, PopupMenuClient*);
49 ~PopupMenuChromium(); 49 virtual ~PopupMenuChromium();
50 50
51 virtual void show(const FloatQuad& controlPosition, const IntSize& controlSi ze, int index) OVERRIDE; 51 virtual void show(const FloatQuad& controlPosition, const IntSize& controlSi ze, int index) OVERRIDE;
52 virtual void hide() OVERRIDE; 52 virtual void hide() OVERRIDE;
53 virtual void updateFromElement() OVERRIDE; 53 virtual void updateFromElement() OVERRIDE;
54 virtual void disconnectClient() OVERRIDE; 54 virtual void disconnectClient() OVERRIDE;
55 55
56 static int minimumRowHeight() { return s_minimumRowHeight; } 56 static int minimumRowHeight() { return s_minimumRowHeight; }
57 static void setMinimumRowHeight(int minimumRowHeight) { s_minimumRowHeight = minimumRowHeight; } 57 static void setMinimumRowHeight(int minimumRowHeight) { s_minimumRowHeight = minimumRowHeight; }
58 static int optionRowHeightForTouch() { return s_optionRowHeightForTouch; } 58 static int optionRowHeightForTouch() { return s_optionRowHeightForTouch; }
59 static void setOptionRowHeightForTouch(int optionRowHeightForTouch) { s_opti onRowHeightForTouch = optionRowHeightForTouch; } 59 static void setOptionRowHeightForTouch(int optionRowHeightForTouch) { s_opti onRowHeightForTouch = optionRowHeightForTouch; }
60 60
61 private: 61 private:
62 PopupMenuClient* client() const { return m_popupClient; } 62 PopupMenuClient* client() const { return m_popupClient; }
63 63
64 PopupMenuClient* m_popupClient; 64 PopupMenuClient* m_popupClient;
65 RefPtr<FrameView> m_frameView; 65 RefPtr<FrameView> m_frameView;
66 RefPtr<PopupContainer> m_popup; 66 RefPtr<PopupContainer> m_popup;
67 67
68 static int s_minimumRowHeight; 68 static int s_minimumRowHeight;
69 static int s_optionRowHeightForTouch; 69 static int s_optionRowHeightForTouch;
70 }; 70 };
71 71
72 } // namespace WebCore 72 } // namespace WebCore
73 73
74 #endif 74 #endif
OLDNEW
« no previous file with comments | « Source/web/PopupListBox.h ('k') | Source/web/PrerendererClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698