Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 135753002: Update web classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/FrameLoaderClientImpl.h ('k') | Source/web/GeolocationClientMock.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 if (m_webFrame->permissionClient()) 227 if (m_webFrame->permissionClient())
228 m_webFrame->permissionClient()->didNotAllowPlugins(m_webFrame); 228 m_webFrame->permissionClient()->didNotAllowPlugins(m_webFrame);
229 229
230 } 230 }
231 231
232 bool FrameLoaderClientImpl::hasWebView() const 232 bool FrameLoaderClientImpl::hasWebView() const
233 { 233 {
234 return m_webFrame->viewImpl(); 234 return m_webFrame->viewImpl();
235 } 235 }
236 236
237 bool FrameLoaderClientImpl::hasFrameView() const
238 {
239 // The Mac port has this notion of a WebFrameView, which seems to be
240 // some wrapper around an NSView. Since our equivalent is HWND, I guess
241 // we have a "frameview" whenever we have the toplevel HWND.
242 return m_webFrame->viewImpl();
243 }
244
245 void FrameLoaderClientImpl::detachedFromParent() 237 void FrameLoaderClientImpl::detachedFromParent()
246 { 238 {
247 // Alert the client that the frame is being detached. This is the last 239 // Alert the client that the frame is being detached. This is the last
248 // chance we have to communicate with the client. 240 // chance we have to communicate with the client.
249 RefPtr<WebFrameImpl> protector(m_webFrame); 241 RefPtr<WebFrameImpl> protector(m_webFrame);
250 242
251 WebFrameClient* client = m_webFrame->client(); 243 WebFrameClient* client = m_webFrame->client();
252 if (!client) 244 if (!client)
253 return; 245 return;
254 246
(...skipping 504 matching lines...) Expand 10 before | Expand all | Expand 10 after
759 return m_webFrame->sharedWorkerRepositoryClient(); 751 return m_webFrame->sharedWorkerRepositoryClient();
760 } 752 }
761 753
762 void FrameLoaderClientImpl::didStopAllLoaders() 754 void FrameLoaderClientImpl::didStopAllLoaders()
763 { 755 {
764 if (m_webFrame->client()) 756 if (m_webFrame->client())
765 m_webFrame->client()->didAbortLoading(m_webFrame); 757 m_webFrame->client()->didAbortLoading(m_webFrame);
766 } 758 }
767 759
768 } // namespace blink 760 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/FrameLoaderClientImpl.h ('k') | Source/web/GeolocationClientMock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698