Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1357523003: Hook up "--threads" to gn help. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hook up "--threads" to gn help. This was documented but the flag was not hooked up to the help system so it didn't actually appear in "gn help switches". Committed: https://crrev.com/62ce4f0ee6778343f52682294dc63784b02a7907 Cr-Commit-Position: refs/heads/master@{#349500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gn/switches.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
brettw
5 years, 3 months ago (2015-09-17 19:11:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357523003/1
5 years, 3 months ago (2015-09-17 19:12:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 19:28:41 UTC) #6
jam
lgtm
5 years, 3 months ago (2015-09-17 21:28:42 UTC) #7
jam
lgtm lgtm
5 years, 3 months ago (2015-09-17 21:28:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357523003/1
5 years, 3 months ago (2015-09-17 21:34:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 21:41:28 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 21:43:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62ce4f0ee6778343f52682294dc63784b02a7907
Cr-Commit-Position: refs/heads/master@{#349500}

Powered by Google App Engine
This is Rietveld 408576698