Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Issue 1357513002: Revert of Add accelerated VP9 decode infrastructure and an implementation for VA-API. (Closed)

Created:
5 years, 3 months ago by tommycli
Modified:
5 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, fgalligan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add accelerated VP9 decode infrastructure and an implementation for VA-API. (patchset #7 id:260001 of https://codereview.chromium.org/1318863003/ ) Reason for revert: I think this patch broke compile step for Chromium Linux ChromeOS MSan Builder. First failing build: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20ChromeOS%20MSan%20Builder/builds/8310 All recent builds: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20ChromeOS%20MSan%20Builder?numbuilds=200 Sorry for the revert. I'll re-revert if I'm wrong. Cheers, Tommy Original issue's description: > Add accelerated VP9 decode infrastructure and an implementation for VA-API. > > - Add a hardware/platform-independent VP9Decoder class and related > infrastructure, implementing AcceleratedVideoDecoder interface. VP9Decoder > performs the initial stages of the decode process, which are to be done > on host/in software, such as stream parsing and reference frame management. > > - Add a VP9Accelerator interface, used by the VP9Decoder to offload the > remaining stages of the decode process to hardware. VP9Accelerator > implementations are platform-specific. > > - Add the first implementation of VP9Accelerator - VaapiVP9Accelerator - and > integrate it with VaapiVideoDecodeAccelerator, for devices which provide > hardware VP9 acceleration through VA-API. Hook it up to the new > infrastructure and VP9Decoder. > > - Extend Vp9Parser to provide functionality required by VP9Decoder and > VP9Accelerator, including superframe parsing, handling of loop filter > and segmentation initialization, state persistence across frames and > resetting when needed. Also add code calculating segmentation dequants > and loop filter levels. > > - Update vp9_parser_unittest to the new Vp9Parser interface and flow. > > TEST=vp9_parser_unittest,vda_unittest,Chrome VP9 playback > BUG=chrome-os-partner:41469, chrome-os-partner:41470, chromium:525331 > TBR=dpranke@chromium.org > > Committed: https://crrev.com/e3cc0a661b8abfdc74f569940949bc1f336ece40 > Cr-Commit-Position: refs/heads/master@{#349312} TBR=wuchengli@chromium.org,kcwu@chromium.org,sandersd@chromium.org,jorgelo@chromium.org,posciak@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chrome-os-partner:41469, chrome-os-partner:41470, chromium:525331 Committed: https://crrev.com/27c68f543e5eba779902447445dfb05ec3f5bf75 Cr-Commit-Position: refs/heads/master@{#349443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -1138 lines) Patch
M content/common/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 12 chunks +13 lines, -227 lines 0 comments Download
M content/common/gpu/media/vaapi_wrapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/gpu/media/vp9_decoder.h View 1 chunk +0 lines, -128 lines 0 comments Download
D content/common/gpu/media/vp9_decoder.cc View 1 chunk +0 lines, -180 lines 0 comments Download
D content/common/gpu/media/vp9_picture.h View 1 chunk +0 lines, -35 lines 0 comments Download
D content/common/gpu/media/vp9_picture.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M content/common/sandbox_linux/bpf_gpu_policy_linux.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M media/filters/vp9_parser.h View 10 chunks +59 lines, -129 lines 0 comments Download
M media/filters/vp9_parser.cc View 10 chunks +73 lines, -362 lines 0 comments Download
M media/filters/vp9_parser_unittest.cc View 5 chunks +29 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tommycli
Created Revert of Add accelerated VP9 decode infrastructure and an implementation for VA-API.
5 years, 3 months ago (2015-09-17 17:35:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357513002/1
5 years, 3 months ago (2015-09-17 17:35:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 17:37:25 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 17:38:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27c68f543e5eba779902447445dfb05ec3f5bf75
Cr-Commit-Position: refs/heads/master@{#349443}

Powered by Google App Engine
This is Rietveld 408576698