Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: Source/bindings/v8/ScriptDebugServer.h

Issue 13575004: Apply script preprocessor to Web page scripts only. (Closed) Base URL: https://chromium.googlesource.com/external/WebKit_trimmed.git@master
Patch Set: Partial response to review Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ScriptDebugServer.h
diff --git a/Source/bindings/v8/ScriptDebugServer.h b/Source/bindings/v8/ScriptDebugServer.h
index f20adaaf28cd27998a2921407017e5722212c153..c17e6f89780d443ac08e551d2b3b7363ed130afd 100644
--- a/Source/bindings/v8/ScriptDebugServer.h
+++ b/Source/bindings/v8/ScriptDebugServer.h
@@ -44,6 +44,7 @@
namespace WebCore {
+class ScriptController;
class ScriptDebugListener;
class ScriptObject;
class ScriptState;
@@ -75,8 +76,6 @@ public:
bool setScriptSource(const String& sourceID, const String& newContent, bool preview, String* error, ScriptValue* newCallFrames, ScriptObject* result);
void updateCallStack(ScriptValue* callFrame);
- void setScriptPreprocessor(const String& preprocessorBody);
-
class Task {
public:
virtual ~Task() { }
@@ -96,6 +95,7 @@ public:
virtual void compileScript(ScriptState*, const String& expression, const String& sourceURL, String* scriptId, String* exceptionMessage);
virtual void clearCompiledScripts();
virtual void runScript(ScriptState*, const String& scriptId, ScriptValue* result, bool* wasThrown, String* exceptionMessage);
+ virtual ScriptController* scriptController(v8::Handle<v8::Context>);
protected:
explicit ScriptDebugServer(v8::Isolate*);
@@ -131,8 +131,7 @@ protected:
v8::Isolate* m_isolate;
private:
- class ScriptPreprocessor;
- OwnPtr<ScriptPreprocessor> m_scriptPreprocessor;
+ void preprocess(v8::Handle<v8::Context>, v8::Handle<v8::Object> eventData);
bool m_runningNestedMessageLoop;
};

Powered by Google App Engine
This is Rietveld 408576698