Source/bindings/v8/ScriptController.h - Issue 13575004: Apply script preprocessor to Web page scripts only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptController.h

Issue 13575004: Apply script preprocessor to Web page scripts only. (Closed) Base URL: https://chromium.googlesource.com/external/WebKit_trimmed.git@master

Patch Set: Re-implment based on review Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/ScriptController.h

diff --git a/Source/bindings/v8/ScriptController.h b/Source/bindings/v8/ScriptController.h

index 38421d46213a958f14765e7cc7811fa597190524..94057d568b93235db32bbf8512f25a1952a6e627 100644

--- a/Source/bindings/v8/ScriptController.h

+++ b/Source/bindings/v8/ScriptController.h

@@ -96,6 +96,8 @@ public:

// Evaluate JavaScript in the main world.

// The caller must hold an execution context.

ScriptValue evaluate(const ScriptSourceCode&);

+ // Evaluate Web-origin JavaScript in the main world. (Not for system uses)

pfeldman 2013/05/29 15:03:52 Insert blank line above the comment. I think this

+ ScriptValue evaluateFromWebPage(const ScriptSourceCode&);

// Executes JavaScript in an isolated world. The script gets its own global scope,

// its own prototypes for intrinsic JavaScript objects (String, Array, and so-on),

« no previous file with comments | « no previous file | Source/bindings/v8/ScriptController.cpp » ('j') | Source/core/dom/ScriptElement.cpp » ('J')