Source/bindings/v8/PageScriptDebugServer.cpp - Issue 13575004: Apply script preprocessor to Web page scripts only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/PageScriptDebugServer.cpp

Issue 13575004: Apply script preprocessor to Web page scripts only. (Closed) Base URL: https://chromium.googlesource.com/external/WebKit_trimmed.git@master

Patch Set: Rebase, simplify Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/WebKit/chromium/src/WebScopedCompilation.cpp ('k') | Source/bindings/v8/ScriptDebugServer.cpp » ('j') | Source/bindings/v8/ScriptDebugServer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/PageScriptDebugServer.cpp

diff --git a/Source/bindings/v8/PageScriptDebugServer.cpp b/Source/bindings/v8/PageScriptDebugServer.cpp

index 680f69d87a54f1d19472aca81063efba9af3c05b..d87f063dcff490bb2ba3d3d4ef81cdca150bfb09 100644

--- a/Source/bindings/v8/PageScriptDebugServer.cpp

+++ b/Source/bindings/v8/PageScriptDebugServer.cpp

@@ -166,6 +166,11 @@ void PageScriptDebugServer::runScript(ScriptState* state, const String& scriptId

ScriptDebugListener* PageScriptDebugServer::getDebugListenerForContext(v8::Handle<v8::Context> context)

{

v8::HandleScope scope;

+ // System-created contexts will crash retrieveFrameWithGlobalCheck

+ if (V8PerContextDebugData::contextDebugId(context) < 0)

+ return 0;

Frame* frame = retrieveFrameWithGlobalObjectCheck(context);

if (!frame)

return 0;