Issue 13575003: drive: Make DriveFileSystem::CheckForUpdates() safer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13575003: drive: Make DriveFileSystem::CheckForUpdates() safer (Closed)

Created:
7 years, 8 months ago by satorux1

Modified:
7 years, 8 months ago

Reviewers:
kinaba

CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Make DriveFileSystem::CheckForUpdates() safer Previously, calling this function crashed, if ChangeListLoader is not yet created. This change is in preparation for writing browser tests for Drive in Files.app BUG=224534 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192476

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/chromeos/drive/drive_file_system.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/13575003/1

7 years, 8 months ago (2013-04-05 01:37:28 UTC) #3

satorux1

7 years, 8 months ago (2013-04-05 03:40:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r192476 (presubmit successful).

Expand Messages | Collapse Messages