Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1357433003: Revert of ozone: gbm: Default use_system_minigbm=1 to mitigate build breaks (Closed)

Created:
5 years, 3 months ago by spang
Modified:
5 years, 3 months ago
Reviewers:
dnicoara
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ozone: gbm: Default use_system_minigbm=1 to mitigate build breaks (patchset #3 id:40001 of https://codereview.chromium.org/1344263002/ ) Reason for revert: This should work now. Original issue's description: > ozone: gbm: Default use_system_minigbm=1 to mitigate build breaks > > The chrome-sdk needs to update with the flag to avoid breakage. > This CL can be reverted when the chrome-sdk updates with the > new use_system_minigbm setting in GYP_DEFINES. > > TBR=dnicoara (build break) > NOTRY=true > > Committed: https://crrev.com/0e8f0106e7e01cee911dd2b34c263c01788e7186 > Cr-Commit-Position: refs/heads/master@{#349041} TBR=dnicoara@chromium.org Committed: https://crrev.com/fcef2de97794abf899bb3efe78657355661c7b3d Cr-Commit-Position: refs/heads/master@{#349450}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/minigbm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/minigbm/minigbm.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/ozone.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
spang
Created Revert of ozone: gbm: Default use_system_minigbm=1 to mitigate build breaks
5 years, 3 months ago (2015-09-17 16:29:38 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357433003/1
5 years, 3 months ago (2015-09-17 16:40:31 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 18:03:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357433003/1
5 years, 3 months ago (2015-09-17 18:05:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 18:11:33 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fcef2de97794abf899bb3efe78657355661c7b3d Cr-Commit-Position: refs/heads/master@{#349450}
5 years, 3 months ago (2015-09-17 18:12:14 UTC) #9
Pawel Osciak
5 years, 3 months ago (2015-09-18 02:23:13 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1357573002/ by posciak@chromium.org.

The reason for reverting is: UI does not come up on x86 with below errors:

ERROR:gbm_device.cc(26)] Unable to initialize GBM for /dev/dri/card0: Invalid
argument
ERROR:drm_device_manager.cc(54)] Could not initialize DRM device for
/dev/dri/card0

Revert seems to be fixing that..

Powered by Google App Engine
This is Rietveld 408576698