Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1357423011: Support alternative locale zip (Closed)

Created:
5 years, 3 months ago by michaelbai
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support alternative locale zip Instead of using the locale zip in dep graph, alternative locale zip could be used when building APK. - Using dedicated variables in all_dependencies_settings for locale zip - Not using locale zip from all_dependences_settings if alternative file specified. - Make resources_zip_path in locale_pak_resources.gypi setable, so the file could be used as alternative lcoale zip for APK. BUG=535379 Committed: https://crrev.com/c0ca6bacc1e4bb753d451618d84fc3700089d7c9 Cr-Commit-Position: refs/heads/master@{#351190}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -11 lines) Patch
M build/android/locale_pak_resources.gypi View 2 chunks +5 lines, -3 lines 0 comments Download
M build/java.gypi View 7 chunks +13 lines, -3 lines 0 comments Download
M build/java_apk.gypi View 6 chunks +31 lines, -5 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
michaelbai
5 years, 3 months ago (2015-09-24 04:19:45 UTC) #2
michaelbai
On 2015/09/24 04:19:45, michaelbai wrote: ping
5 years, 2 months ago (2015-09-25 16:52:20 UTC) #3
jbudorick
Should there be a matching GN change? https://codereview.chromium.org/1357423011/diff/1/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/1357423011/diff/1/build/java_apk.gypi#newcode71 build/java_apk.gypi:71: # dependencies_locale_zip_alternative_paths ...
5 years, 2 months ago (2015-09-28 17:58:25 UTC) #4
jbudorick
lgtm after offline discussion
5 years, 2 months ago (2015-09-28 19:04:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357423011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357423011/1
5 years, 2 months ago (2015-09-28 20:39:35 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 22:50:31 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 22:52:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0ca6bacc1e4bb753d451618d84fc3700089d7c9
Cr-Commit-Position: refs/heads/master@{#351190}

Powered by Google App Engine
This is Rietveld 408576698