Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1357423008: [Telemetry] AddIsEventInInteractions helper method (Closed)

Created:
5 years, 3 months ago by nednguyen
Modified:
5 years, 2 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add a helper method for checking whether an event fall in the ranges of interaction records Committed: https://crrev.com/aa7c6661a83d3ff9c3baee88462476c19a210a3b Cr-Commit-Position: refs/heads/master@{#351086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M tools/telemetry/telemetry/web_perf/metrics/timeline_based_metric.py View 1 chunk +17 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/timeline_based_metric_unittest.py View 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
nednguyen
5 years, 3 months ago (2015-09-23 22:12:01 UTC) #2
aiolos (Not reviewing)
lgtm
5 years, 3 months ago (2015-09-23 22:16:07 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357423008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357423008/1
5 years, 3 months ago (2015-09-23 22:16:20 UTC) #5
eakuefner
lgtm
5 years, 3 months ago (2015-09-23 22:20:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357423008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357423008/1
5 years, 3 months ago (2015-09-23 22:20:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/44624)
5 years, 3 months ago (2015-09-23 22:36:52 UTC) #11
eakuefner
BTW, your CL description is too long -- consider changing the first line to be ...
5 years, 3 months ago (2015-09-24 18:14:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357423008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357423008/1
5 years, 3 months ago (2015-09-24 18:17:09 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/45084)
5 years, 3 months ago (2015-09-24 18:34:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357423008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357423008/1
5 years, 2 months ago (2015-09-28 15:17:16 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 16:45:06 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 16:45:40 UTC) #20
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aa7c6661a83d3ff9c3baee88462476c19a210a3b
Cr-Commit-Position: refs/heads/master@{#351086}

Powered by Google App Engine
This is Rietveld 408576698