tools/metrics/histograms/histograms.xml - Issue 1357403003: Separate page load metrics for backgrounded pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1357403003: Separate page load metrics for backgrounded pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a started_in_foreground boolean to PageLoadTracker for clarity Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/page_load_metrics/browser/metrics_web_contents_observer.cc ('K') | « components/page_load_metrics/renderer/metrics_render_frame_observer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 601cee84d75b23938d0d865e3d9ce336c33ce0f6..42e8c23ce0be86a014d55b29ea4f1fed92dbe266 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -29710,6 +29710,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<histogram name="PageLoad.Timing.NavigationToDOMContentLoadedEventFired"

units="milliseconds">

<owner>bmcquade@chromium.org</owner>

+ <owner>csharrison@chromium.org</owner>

Measures the time from navigation timing's navigation start to the time the

DOMContentLoaded event is fired, for main frame documents.

@@ -29718,6 +29719,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>bmcquade@chromium.org</owner>

+ <owner>csharrison@chromium.org</owner>

Measures the time from navigation timing's navigation start to the time the

first layout is performed, for main frame documents.

@@ -29727,6 +29729,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<histogram name="PageLoad.Timing.NavigationToLoadEventFired"

units="milliseconds">

<owner>bmcquade@chromium.org</owner>

+ <owner>csharrison@chromium.org</owner>

Measures the time from navigation timing's navigation start to the time the

load event is fired, for main frame documents.

@@ -77141,6 +77144,15 @@ To add a new entry, add it with any value and run test to compute valid value.

<affected-histogram name="PLT.LoadType"/>

</histogram_suffixes>

+<histogram_suffixes name="PageLoadBackgrounded" separator=".">

+ <suffix name="BG"

+ label="Event occurred at least partially in the background"/>

+ <affected-histogram

+ name="PageLoad.Timing.NavigationToDOMContentLoadedEventFired"/>

+ <affected-histogram name="PageLoad.Timing.NavigationToFirstLayout"/>

+ <affected-histogram name="PageLoad.Timing.NavigationToLoadEventFired"/>

+</histogram_suffixes>

<histogram_suffixes name="PageLoadType">

<suffix name="HistoryLoad"

label="but only for user pressing back or forward"/>