Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 135733005: Fix flags for ARM GN build. (Closed)

Created:
6 years, 11 months ago by brettw
Modified:
6 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Fix flags for ARM GN build. I accidentally used underscores which gives undefined option errors. TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/config/compiler/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/135733005/1
6 years, 11 months ago (2014-01-15 02:48:47 UTC) #1
brettw
Committed patchset #1 manually as r244838 (presubmit successful).
6 years, 11 months ago (2014-01-15 06:06:40 UTC) #2
scottmg
6 years, 11 months ago (2014-01-15 06:29:26 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698