[FastTextAutosizer] Incorporate accessibility and device scale factors

[FastTextAutosizer] Incorporate accessibility and device scale factors

This patch incorporates the accessibility font scale factor and the
device scale adjustment into the multiplier calculation. For performance,
these scale factors are only accessed in prepareRenderViewInfo. In
addition, a debug-only assert has been added to ensure
prepareRenderViewInfo is called before the multiplier is calculated.

With this patch we pass 1 additional test!

BUG=333124
R=skobes
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165014

[skobes, 2014-01-13 19:10:13]

lgtm

https://codereview.chromium.org/135733002/diff/1/Source/core/rendering/FastTe...
File Source/core/rendering/FastTextAutosizer.cpp (right):

https://codereview.chromium.org/135733002/diff/1/Source/core/rendering/FastTe...
Source/core/rendering/FastTextAutosizer.cpp:237: float multiplier =
min(blockWidth, (float) m_layoutWidth) / m_windowWidth;
I should have used static_cast<float> here, do you mind fixing it?

https://codereview.chromium.org/135733002/diff/1/Source/core/rendering/FastTe...
File Source/core/rendering/FastTextAutosizer.h (right):

https://codereview.chromium.org/135733002/diff/1/Source/core/rendering/FastTe...
Source/core/rendering/FastTextAutosizer.h:116: float m_additionalMultiplier; //
Includes accessibility font scale factor and device scale adjustment.
Perhaps "m_baseMultiplier"?

https://codereview.chromium.org/135733002/diff/1/Source/core/rendering/FastTe...
Source/core/rendering/FastTextAutosizer.h:117: #ifndef NDEBUG
Is the compiler not smart enough to strip out an unused field in the release
build?

[pdr., 2014-01-13 19:49:11]

https://codereview.chromium.org/135733002/diff/1/Source/core/rendering/FastTe...
File Source/core/rendering/FastTextAutosizer.cpp (right):

https://codereview.chromium.org/135733002/diff/1/Source/core/rendering/FastTe...
Source/core/rendering/FastTextAutosizer.cpp:237: float multiplier =
min(blockWidth, (float) m_layoutWidth) / m_windowWidth;
On 2014/01/13 19:10:13, skobes wrote:
> I should have used static_cast<float> here, do you mind fixing it?

Done.

https://codereview.chromium.org/135733002/diff/1/Source/core/rendering/FastTe...
File Source/core/rendering/FastTextAutosizer.h (right):

https://codereview.chromium.org/135733002/diff/1/Source/core/rendering/FastTe...
Source/core/rendering/FastTextAutosizer.h:116: float m_additionalMultiplier; //
Includes accessibility font scale factor and device scale adjustment.
On 2014/01/13 19:10:13, skobes wrote:
> Perhaps "m_baseMultiplier"?

I like it. Done.

https://codereview.chromium.org/135733002/diff/1/Source/core/rendering/FastTe...
Source/core/rendering/FastTextAutosizer.h:117: #ifndef NDEBUG
On 2014/01/13 19:10:13, skobes wrote:
> Is the compiler not smart enough to strip out an unused field in the release
> build?

Nowhere near smart enough :)

There are two reasons for using #ifndef NDEBUG here:
1) It will force a compile-time failure if we accidentally reference it outside
of a debug build
2) The compiler has a very local view of this class. For example, a separate
program could reference this object and would expect its layout (member
variables, etc) to be there. This is, of course, rare and maybe optimization
should be opt-out instead of opt-in, but that's a question for the c++ gods.

[commit-bot: I haz the power, 2014-01-13 19:49:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/135733002/80001

[commit-bot: I haz the power, 2014-01-14 00:04:23]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[pdr., 2014-01-14 00:34:56]

On 2014/01/14 00:04:23, I haz the power (commit-bot) wrote:
> Retried try job too often on win_blink_rel for step(s) webkit_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

I've investigated the win_blink_rel failure and it's a flake. Committing with
NOTRY=true.

[commit-bot: I haz the power, 2014-01-14 00:35:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/135733002/80001

[commit-bot: I haz the power, 2014-01-14 00:36:36]

Change committed as 165014