Check that element type correct in vector insert element.

Check that element type correct in vector insert element.

Fixes bug where pnacl-sz was not checking if the inserted type matched
the element type of the corresponding vector. Also fixes operand look
up (within a function) to error recover rather than always die with a
fatal error.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4313
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=43632b954abab0a7dcca3441a5e9239be98f6328

[Karl, 2015-09-21 21:33:51]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-09-21 21:39:54]

lgtm

https://codereview.chromium.org/1357273004/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1357273004/diff/1/src/PNaClTranslator.cpp#new...
src/PNaClTranslator.cpp:2298: StrBuf << "Element type " <<
Ice::typeString(Elt->getType())
May want to use the string "insertelement" in the error message.  I think that
style is used elsewhere.

[Karl, 2015-09-21 22:32:34]

Committed patchset #2 (id:20001) manually as
43632b954abab0a7dcca3441a5e9239be98f6328 (presubmit successful).

[Karl, 2015-09-21 22:32:47]

https://codereview.chromium.org/1357273004/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1357273004/diff/1/src/PNaClTranslator.cpp#new...
src/PNaClTranslator.cpp:2298: StrBuf << "Element type " <<
Ice::typeString(Elt->getType())
On 2015/09/21 21:39:54, stichnot wrote:
> May want to use the string "insertelement" in the error message.  I think that
> style is used elsewhere.

Done.