Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: components/autofill/core/browser/autofill_external_delegate.cc

Issue 1357243003: Content description for settings button in keyboard accessory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix iOS. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_external_delegate.cc
diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc
index 82b7396c7c8f999ac184d9885014910a9f031e49..12cf0e0bd76141e3e5324dc7f687503476b48783 100644
--- a/components/autofill/core/browser/autofill_external_delegate.cc
+++ b/components/autofill/core/browser/autofill_external_delegate.cc
@@ -293,8 +293,9 @@ void AutofillExternalDelegate::ApplyAutofillOptions(
}
// Append the 'Chrome Autofill options' menu item;
- suggestions->push_back(Suggestion(
- l10n_util::GetStringUTF16(IDS_AUTOFILL_OPTIONS_POPUP)));
+ suggestions->push_back(Suggestion(l10n_util::GetStringUTF16(
+ IsKeyboardAccessoryEnabled() ? IDS_AUTOFILL_OPTIONS_CONTENT_DESCRIPTION
Evan Stade 2015/09/21 20:03:47 this seems like another place we should just switc
please use gerrit instead 2015/09/21 20:34:44 Added a TODO. Done.
+ : IDS_AUTOFILL_OPTIONS_POPUP)));
suggestions->back().frontend_id = POPUP_ITEM_ID_AUTOFILL_OPTIONS;
if (IsKeyboardAccessoryEnabled())
suggestions->back().icon = base::ASCIIToUTF16("settings");

Powered by Google App Engine
This is Rietveld 408576698