Issue 1357243002: Merge to XFA:More tidy of CJS_Object, kill implicit cast operator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1357243002: Merge to XFA:More tidy of CJS_Object, kill implicit cast operator (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA:More tidy of CJS_Object, kill implicit cast operator (cherry picked from commit 270fc65d5824eeedbb2ed17516a72721bde9c9ef) Original Review URL: https://codereview.chromium.org/1349423006 . TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/116e4addeecd2cb779b1ab590bea2d091ca12915

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -41 lines)			Patch
M	fpdfsdk/include/javascript/JS_Object.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Object.cpp	View	1 chunk	+8 lines, -9 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Value.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	fpdfsdk/src/javascript/global.cpp	View	4 chunks	+17 lines, -25 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as 116e4addeecd2cb779b1ab590bea2d091ca12915 (presubmit successful).

5 years, 3 months ago (2015-09-21 16:22:09 UTC) #2

Message was sent while issue was closed.

lgtm