Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1357233002: Stage sloppy block-scoped functions (Annex B 3.3) (Closed)

Created:
5 years, 3 months ago by Dan Ehrenberg
Modified:
5 years, 3 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage sloppy block-scoped functions (Annex B 3.3) Turn on some test262 tests that pass now. R=adamk LOG=Y BUG=v8:4285 Committed: https://crrev.com/6e07f5a75ba2c949ac96efabd5248c76b9957112 Cr-Commit-Position: refs/heads/master@{#30853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -25 lines) Patch
M src/flag-definitions.h View 1 chunk +16 lines, -16 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dan Ehrenberg
5 years, 3 months ago (2015-09-21 16:00:28 UTC) #1
adamk
lgtm!
5 years, 3 months ago (2015-09-21 16:03:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357233002/1
5 years, 3 months ago (2015-09-21 16:03:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 16:30:31 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 16:30:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e07f5a75ba2c949ac96efabd5248c76b9957112
Cr-Commit-Position: refs/heads/master@{#30853}

Powered by Google App Engine
This is Rietveld 408576698