Add CORS support for <link> elements.

Add CORS support for <link> elements.

The HTMLLinkElement object supports CORS-enabled fetches,

  http://www.whatwg.org/specs/web-apps/current-work/#htmllinkelement

by using the 'crossorigin' attribute. Extend HTMLLinkElement loading
to support this over its link types, in particular / of note,
"stylesheet" and "subresource" / "prefetch".

R=abarth@chromium.org
BUG=178787
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165923

[sof, 2014-01-27 22:48:21]

If you have the time at some point, please take a look.

Building on the previous CORS-related CL.

[abarth-chromium, 2014-01-28 06:38:45]

lgtm

https://codereview.chromium.org/135723008/diff/1/Source/core/html/HTMLLinkEle...
File Source/core/html/HTMLLinkElement.cpp (right):

https://codereview.chromium.org/135723008/diff/1/Source/core/html/HTMLLinkEle...
Source/core/html/HTMLLinkElement.cpp:600: StoredCredentials allowCredentials =
equalIgnoringCase(crossOriginMode, "use-credentials") ? AllowStoredCredentials :
DoNotAllowStoredCredentials;
Should we make a helper function that does this work?  I feel like we have this
same line of code copy/pasted in a bunch of places.

https://codereview.chromium.org/135723008/diff/1/Source/core/html/HTMLLinkEle...
File Source/core/html/HTMLLinkElement.h (right):

https://codereview.chromium.org/135723008/diff/1/Source/core/html/HTMLLinkEle...
Source/core/html/HTMLLinkElement.h:159: bool loadLink(const String&, const
KURL&);
I'd probably keep the name |type| for the first argument because it's not clear
from context what it means.

https://codereview.chromium.org/135723008/diff/1/Source/core/loader/LinkLoade...
File Source/core/loader/LinkLoader.cpp (right):

https://codereview.chromium.org/135723008/diff/1/Source/core/loader/LinkLoade...
Source/core/loader/LinkLoader.cpp:118: StoredCredentials allowCredentials =
equalIgnoringCase(crossOriginMode, "use-credentials") ? AllowStoredCredentials :
DoNotAllowStoredCredentials;
It's even twice in this CL.  :)

[sof, 2014-01-28 07:23:00]

https://codereview.chromium.org/135723008/diff/1/Source/core/html/HTMLLinkEle...
File Source/core/html/HTMLLinkElement.cpp (right):

https://codereview.chromium.org/135723008/diff/1/Source/core/html/HTMLLinkEle...
Source/core/html/HTMLLinkElement.cpp:600: StoredCredentials allowCredentials =
equalIgnoringCase(crossOriginMode, "use-credentials") ? AllowStoredCredentials :
DoNotAllowStoredCredentials;
On 2014/01/28 06:38:45, abarth wrote:
> Should we make a helper function that does this work?  I feel like we have
this
> same line of code copy/pasted in a bunch of places.

Great suggestion, less repetition.

Added FetchRequest::setCrossOriginAccessControl(securityOrigin, crossOriginMode)
(and used it without abandon.)

https://codereview.chromium.org/135723008/diff/1/Source/core/html/HTMLLinkEle...
File Source/core/html/HTMLLinkElement.h (right):

https://codereview.chromium.org/135723008/diff/1/Source/core/html/HTMLLinkEle...
Source/core/html/HTMLLinkElement.h:159: bool loadLink(const String&, const
KURL&);
On 2014/01/28 06:38:45, abarth wrote:
> I'd probably keep the name |type| for the first argument because it's not
clear
> from context what it means.

Yes, added 'type' back here + expanded LinkLoader::loadLink()'s declaration
similarly.

[commit-bot: I haz the power, 2014-01-28 08:36:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/135723008/20001

[commit-bot: I haz the power, 2014-01-28 09:49:32]

Change committed as 165923