Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: content/browser/frame_host/interstitial_page_impl.h

Issue 135723003: Move DidCommitProvisionalLoad code from RenderView to RenderFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed unit tests and removed WebContents::DidNavigate Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/interstitial_page_impl.h
diff --git a/content/browser/frame_host/interstitial_page_impl.h b/content/browser/frame_host/interstitial_page_impl.h
index 36e0807492a12b0cc542a1b824ea2002da55433e..6122d08060b5d1ef766a1ca2f669e11b895c1695 100644
--- a/content/browser/frame_host/interstitial_page_impl.h
+++ b/content/browser/frame_host/interstitial_page_impl.h
@@ -91,6 +91,13 @@ class CONTENT_EXPORT InterstitialPageImpl
RenderViewHost* GetRenderViewHost() const;
#endif
+ // RenderViewHostDelegate implementation:
Charlie Reis 2014/02/06 21:49:07 We can remove this line, since it's no longer in R
nasko 2014/02/06 21:58:43 Done.
+ // TODO(nasko): This should move to InterstitialPageNavigatorImpl, but in
+ // the meantime make it public, so it can be called directly.
+ void DidNavigate(
+ RenderViewHost* render_view_host,
+ const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
+
protected:
// NotificationObserver method:
virtual void Observe(int type,
@@ -111,9 +118,6 @@ class CONTENT_EXPORT InterstitialPageImpl
virtual void RenderViewTerminated(RenderViewHost* render_view_host,
base::TerminationStatus status,
int error_code) OVERRIDE;
- virtual void DidNavigate(
- RenderViewHost* render_view_host,
- const ViewHostMsg_FrameNavigate_Params& params) OVERRIDE;
virtual void UpdateTitle(RenderViewHost* render_view_host,
int32 page_id,
const base::string16& title,

Powered by Google App Engine
This is Rietveld 408576698