Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 135723003: Move DidCommitProvisionalLoad code from RenderView to RenderFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Some clean up, ready to start reviewing. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 // into WebContentsObserver::FrameDetached for now. 91 // into WebContentsObserver::FrameDetached for now.
92 RenderFrameHostImpl(RenderViewHostImpl* render_view_host, 92 RenderFrameHostImpl(RenderViewHostImpl* render_view_host,
93 RenderFrameHostDelegate* delegate, 93 RenderFrameHostDelegate* delegate,
94 FrameTree* frame_tree, 94 FrameTree* frame_tree,
95 FrameTreeNode* frame_tree_node, 95 FrameTreeNode* frame_tree_node,
96 int routing_id, 96 int routing_id,
97 bool is_swapped_out); 97 bool is_swapped_out);
98 98
99 private: 99 private:
100 friend class TestRenderViewHost; 100 friend class TestRenderViewHost;
101 friend class TestRenderFrameHost;
Charlie Reis 2014/02/05 23:30:37 nit: Alphabetize.
nasko 2014/02/06 01:55:13 Done.
101 102
102 // IPC Message handlers. 103 // IPC Message handlers.
103 void OnDetach(int64 parent_frame_id, int64 frame_id); 104 void OnDetach(int64 parent_frame_id, int64 frame_id);
104 void OnDidStartProvisionalLoadForFrame(int64 frame_id, 105 void OnDidStartProvisionalLoadForFrame(int64 frame_id,
105 int64 parent_frame_id, 106 int64 parent_frame_id,
106 bool main_frame, 107 bool main_frame,
107 const GURL& url); 108 const GURL& url);
108 void OnDidFailProvisionalLoadWithError( 109 void OnDidFailProvisionalLoadWithError(
109 const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params); 110 const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params);
110 void OnDidRedirectProvisionalLoad(int32 page_id, 111 void OnDidRedirectProvisionalLoad(int32 page_id,
111 const GURL& source_url, 112 const GURL& source_url,
112 const GURL& target_url); 113 const GURL& target_url);
114 void OnNavigate(const IPC::Message& msg);
113 void OnSwapOutACK(); 115 void OnSwapOutACK();
114 void OnContextMenu(const ContextMenuParams& params); 116 void OnContextMenu(const ContextMenuParams& params);
115 117
116 // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a 118 // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a
117 // refcount that calls Shutdown when it reaches zero. This allows each 119 // refcount that calls Shutdown when it reaches zero. This allows each
118 // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring 120 // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring
119 // we have a RenderViewHost for each RenderFrameHost. 121 // we have a RenderViewHost for each RenderFrameHost.
120 // TODO(creis): RenderViewHost will eventually go away and be replaced with 122 // TODO(creis): RenderViewHost will eventually go away and be replaced with
121 // some form of page context. 123 // some form of page context.
122 RenderViewHostImpl* render_view_host_; 124 RenderViewHostImpl* render_view_host_;
(...skipping 22 matching lines...) Expand all
145 147
146 int routing_id_; 148 int routing_id_;
147 bool is_swapped_out_; 149 bool is_swapped_out_;
148 150
149 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 151 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
150 }; 152 };
151 153
152 } // namespace content 154 } // namespace content
153 155
154 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 156 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698