Move DidCommitProvisionalLoad code from RenderView to RenderFrame.

content/browser/frame_host/interstitial_page_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_IMPL_H_
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 73 matching lines @@
     reload_on_dont_proceed_ = value;
   }
   bool reload_on_dont_proceed() const { return reload_on_dont_proceed_; }
 
 #if defined(OS_ANDROID)
   // Android shares a single platform window for all tabs, so we need to expose
   // the RenderViewHost to properly route gestures to the interstitial.
   RenderViewHost* GetRenderViewHost() const;
 #endif
 
+  // RenderViewHostDelegate implementation:
+  // TODO(nasko): This should move to InterstitialPageNavigatorImpl, but in
+  // the meantime, make it public, so it can be called directly.

[Charlie Reis, 2014/02/05 23:30:37]

nit: no comma after public

[nasko, 2014/02/06 01:55:13]

Done.

+  virtual void DidNavigate(
+      RenderViewHost* render_view_host,
+      const FrameHostMsg_DidCommitProvisionalLoad_Params& params) OVERRIDE;
+
  protected:
   // NotificationObserver method:
   virtual void Observe(int type,
                        const NotificationSource& source,
                        const NotificationDetails& details) OVERRIDE;
 
   // WebContentsObserver implementation:
   virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE;
   virtual void NavigationEntryCommitted(
       const LoadCommittedDetails& load_details) OVERRIDE;
 
   // RenderFrameHostDelegate implementation:
   virtual void RenderFrameCreated(RenderFrameHost* render_frame_host) OVERRIDE;
 
   // RenderViewHostDelegate implementation:
   virtual RenderViewHostDelegateView* GetDelegateView() OVERRIDE;
   virtual const GURL& GetURL() const OVERRIDE;
   virtual void RenderViewTerminated(RenderViewHost* render_view_host,
                                     base::TerminationStatus status,
                                     int error_code) OVERRIDE;
-  virtual void DidNavigate(
-      RenderViewHost* render_view_host,
-      const ViewHostMsg_FrameNavigate_Params& params) OVERRIDE;
   virtual void UpdateTitle(RenderViewHost* render_view_host,
                            int32 page_id,
                            const base::string16& title,
                            base::i18n::TextDirection title_direction) OVERRIDE;
   virtual RendererPreferences GetRendererPrefs(
       BrowserContext* browser_context) const OVERRIDE;
   virtual WebPreferences GetWebkitPrefs() OVERRIDE;
   virtual gfx::Rect GetRootWindowResizerRect() const OVERRIDE;
   virtual void CreateNewWindow(
       int render_process_id,
@@ skipping 143 matching lines @@
   base::WeakPtrFactory<InterstitialPageImpl> weak_ptr_factory_;
 
   scoped_refptr<SessionStorageNamespace> session_storage_namespace_;
 
   DISALLOW_COPY_AND_ASSIGN(InterstitialPageImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_IMPL_H_