Add `git cl checkout` to checkout by Rietveld issue

Add `git cl checkout` to checkout by Rietveld issue

For example:

[5165c48...]d:\src\crashpad\crashpad>git cl checkout https://codereview.chromium.org/1355503005
Previous HEAD position was 5165c48... Use argument escaping function in util/win/process_info_test.cc
Switched to branch 'crashpad-info-cross-bitness'

[crashpad-info-cross-bitness]d:\src\crashpad\crashpad>git cl checkout 818433002
Multiple branches match issue 818433002:
0: file_io_open
1: file_io_open-2
2: file_io_open-3
Choose by index: 1
Switched to branch 'file_io_open-2'


R=dpranke@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296823

[Dirk Pranke, 2015-09-22 17:52:34]

https://codereview.chromium.org/1357213003/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1357213003/diff/20001/git_cl.py#newcode3545
git_cl.py:3545: def CMDco(parser, args):
it seems like this should probably be CMDcheckout, even though I hate typing
longer things :(.

https://codereview.chromium.org/1357213003/diff/20001/git_cl.py#newcode3571
git_cl.py:3571: else:
what if there's no match?

https://codereview.chromium.org/1357213003/diff/20001/git_cl.py#newcode3583
git_cl.py:3583: print 'Issue number: %s (%s)' % (cl.GetIssue(),
cl.GetIssueURL())
Why print anything? You told it the issue number on the command line.

[scottmg, 2015-09-22 17:57:23]

https://codereview.chromium.org/1357213003/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1357213003/diff/20001/git_cl.py#newcode3545
git_cl.py:3545: def CMDco(parser, args):
On 2015/09/22 17:52:34, Dirk Pranke wrote:
> it seems like this should probably be CMDcheckout, even though I hate typing
> longer things :(.

Done.

https://codereview.chromium.org/1357213003/diff/20001/git_cl.py#newcode3571
git_cl.py:3571: else:
On 2015/09/22 17:52:34, Dirk Pranke wrote:
> what if there's no match?

Done.

https://codereview.chromium.org/1357213003/diff/20001/git_cl.py#newcode3583
git_cl.py:3583: print 'Issue number: %s (%s)' % (cl.GetIssue(),
cl.GetIssueURL())
On 2015/09/22 17:52:34, Dirk Pranke wrote:
> Why print anything? You told it the issue number on the command line.

Done.

[Dirk Pranke, 2015-09-22 19:23:17]

lgtm w/ nits.

https://codereview.chromium.org/1357213003/diff/40001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1357213003/diff/40001/git_cl.py#newcode3546
git_cl.py:3546: """Checks out a branch associated with a given open Rietveld
issue."""
how do you know that the issue is still open? I'd probably just remove the word
...

https://codereview.chromium.org/1357213003/diff/40001/git_cl.py#newcode3570
git_cl.py:3570: print 'No branch with open issue found for %s.' % target_issue
and reword this message

[scottmg, 2015-09-22 19:34:22]

https://codereview.chromium.org/1357213003/diff/40001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1357213003/diff/40001/git_cl.py#newcode3546
git_cl.py:3546: """Checks out a branch associated with a given open Rietveld
issue."""
On 2015/09/22 19:23:17, Dirk Pranke wrote:
> how do you know that the issue is still open? I'd probably just remove the
word
> ...

When you `git cl land`, branch.<branch>.rietveldissue gets deleted, so I thought
maybe it was clearer. But I could just leave it a bit vague. (Branches that are
landed by CQ would still be found even if they're closed of course.)

Whichever way you think is better...

[Dirk Pranke, 2015-09-22 19:35:28]

On 2015/09/22 19:34:22, scottmg wrote:
> https://codereview.chromium.org/1357213003/diff/40001/git_cl.py
> File git_cl.py (right):
> 
> https://codereview.chromium.org/1357213003/diff/40001/git_cl.py#newcode3546
> git_cl.py:3546: """Checks out a branch associated with a given open Rietveld
> issue."""
> On 2015/09/22 19:23:17, Dirk Pranke wrote:
> > how do you know that the issue is still open? I'd probably just remove the
> word
> > ...
> 
> When you `git cl land`, branch.<branch>.rietveldissue gets deleted, so I
thought
> maybe it was clearer. But I could just leave it a bit vague. (Branches that
are
> landed by CQ would still be found even if they're closed of course.)
> 
> Whichever way you think is better...

People using git cl land is pretty uncommon these days. I'd probably just be
vague.

(though I didn't know about the deleting the issue bit).

[scottmg, 2015-09-22 20:34:11]

On 2015/09/22 19:35:28, Dirk Pranke wrote:
> On 2015/09/22 19:34:22, scottmg wrote:
> > https://codereview.chromium.org/1357213003/diff/40001/git_cl.py
> > File git_cl.py (right):
> > 
> > https://codereview.chromium.org/1357213003/diff/40001/git_cl.py#newcode3546
> > git_cl.py:3546: """Checks out a branch associated with a given open Rietveld
> > issue."""
> > On 2015/09/22 19:23:17, Dirk Pranke wrote:
> > > how do you know that the issue is still open? I'd probably just remove the
> > word
> > > ...
> > 
> > When you `git cl land`, branch.<branch>.rietveldissue gets deleted, so I
> thought
> > maybe it was clearer. But I could just leave it a bit vague. (Branches that
> are
> > landed by CQ would still be found even if they're closed of course.)
> > 
> > Whichever way you think is better...
> 
> People using git cl land is pretty uncommon these days. I'd probably just be
> vague.
> 
> (though I didn't know about the deleting the issue bit).

Done.

[scottmg, 2015-09-22 20:35:31]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2015-09-22 20:35:31]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1357213003/#ps60001
(title: ".")

[commit-bot: I haz the power, 2015-09-22 20:35:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1357213003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1357213003/60001

[Dirk Pranke, 2015-09-22 20:36:10]

lgtm

[commit-bot: I haz the power, 2015-09-22 20:40:39]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296823