Files.app: Clear the stored destination path on clear the drop target.

Files.app: Clear the stored destination path on clear the drop target.

This patch prevents the mouse cursor icon from un-changing after the drop target is cleared when next drop target is not available.

BUG=226006
TEST=drag and drop works on Files.app

NOTRY=True
# for chromeos_chrome trybot passes.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192807

[yoshiki, 2013-04-05 06:10:37]

@mtomasz: PTAL

[mtomasz, 2013-04-05 07:00:27]

On 2013/04/05 06:10:37, yoshiki wrote:
> @mtomasz: PTAL

@yoshiki: I don't understand why this patch fixes that issue. Can you write some
a short explanation, please?

[mtomasz, 2013-04-05 07:00:32]

https://codereview.chromium.org/13572006/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/file_transfer_controller.js
(right):

https://codereview.chromium.org/13572006/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:480: //
Remove the old drag target.
drag -> drop

[yoshiki, 2013-04-08 07:13:47]

On 2013/04/05 07:00:27, mtomasz wrote:
> On 2013/04/05 06:10:37, yoshiki wrote:
> > @mtomasz: PTAL
> 
> @yoshiki: I don't understand why this patch fixes that issue. Can you write
some
> a short explanation, please?

The root cause of the issue is that when the dragging cursor moves to the blank
area of a list or a tree, the stored destination path is not updated to blank.

In this case,
(1) Once, move the dragging cursor to "Google Drive" in the tree. It sets
"/drive" as the destination path.
(2) move the cursor down to the blank area. The destination path keeps "/drive",
but it should be cleared. And the cursor icon isn't change because the
destination path is not changed.
(3) move the cursor right to the blank area at the bottom of the list view. The
destination path keeps "/drive", but it should be cleared. (Note: since the list
itself is set as a drop target, we can drop a file to the list even when the
destination path is empty.)

[mtomasz, 2013-04-08 07:54:25]

On 2013/04/08 07:13:47, yoshiki wrote:
> On 2013/04/05 07:00:27, mtomasz wrote:
> > On 2013/04/05 06:10:37, yoshiki wrote:
> > > @mtomasz: PTAL
> > 
> > @yoshiki: I don't understand why this patch fixes that issue. Can you write
> some
> > a short explanation, please?
> 
> The root cause of the issue is that when the dragging cursor moves to the
blank
> area of a list or a tree, the stored destination path is not updated to blank.
> 
> In this case,
> (1) Once, move the dragging cursor to "Google Drive" in the tree. It sets
> "/drive" as the destination path.
> (2) move the cursor down to the blank area. The destination path keeps
"/drive",
> but it should be cleared. And the cursor icon isn't change because the
> destination path is not changed.
> (3) move the cursor right to the blank area at the bottom of the list view.
The
> destination path keeps "/drive", but it should be cleared. (Note: since the
list
> itself is set as a drop target, we can drop a file to the list even when the
> destination path is empty.)

Thanks for the explanation! lgtm!

[commit-bot: I haz the power, 2013-04-08 08:18:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/13572006/7001

[commit-bot: I haz the power, 2013-04-08 08:25:01]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-08 11:46:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/13572006/7001

[commit-bot: I haz the power, 2013-04-08 11:51:03]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-08 12:18:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/13572006/7001

[commit-bot: I haz the power, 2013-04-08 12:18:26]

Change committed as 192807