Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1357053003: [GCM] Be more aggressive about triggering heartbeats when waking from sleep (Closed)

Created:
5 years, 3 months ago by Nicolas Zea
Modified:
5 years, 3 months ago
Reviewers:
rkaplow, jianli
CC:
chromium-reviews, asvitkine+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GCM] Be more aggressive about triggering heartbeats when waking from sleep As long as ten seconds has elapsed since the machine went to sleep, we'll now force a heartbeat on resume. BUG=526910 Committed: https://crrev.com/62052fe23d2c58db7c63f9e2db1b98ec0f140b9b Cr-Commit-Position: refs/heads/master@{#350226}

Patch Set 1 #

Patch Set 2 : Self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M google_apis/gcm/engine/heartbeat_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/heartbeat_manager.cc View 1 2 chunks +18 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Nicolas Zea
+Jian, PTAL
5 years, 3 months ago (2015-09-18 22:44:58 UTC) #2
Nicolas Zea
ping?
5 years, 3 months ago (2015-09-21 22:17:24 UTC) #3
jianli
lgtm
5 years, 3 months ago (2015-09-21 22:30:01 UTC) #4
Nicolas Zea
+rkaplow for UMA
5 years, 3 months ago (2015-09-21 23:42:23 UTC) #6
rkaplow
lgtm
5 years, 3 months ago (2015-09-22 00:06:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357053003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357053003/20001
5 years, 3 months ago (2015-09-22 00:11:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/114089)
5 years, 3 months ago (2015-09-22 00:22:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357053003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357053003/20001
5 years, 3 months ago (2015-09-22 00:25:35 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/114097)
5 years, 3 months ago (2015-09-22 00:34:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357053003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357053003/20001
5 years, 3 months ago (2015-09-22 20:29:06 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-22 21:13:15 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 21:52:42 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/62052fe23d2c58db7c63f9e2db1b98ec0f140b9b
Cr-Commit-Position: refs/heads/master@{#350226}

Powered by Google App Engine
This is Rietveld 408576698