Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: Source/core/inspector/InspectorResourceAgent.cpp

Issue 135703002: Update inspector classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: No change under web/ Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorResourceAgent.h ('k') | Source/core/inspector/InspectorRuntimeAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorResourceAgent.cpp
diff --git a/Source/core/inspector/InspectorResourceAgent.cpp b/Source/core/inspector/InspectorResourceAgent.cpp
index 22c1167c7b046cec14a7bd8df0b9e6066b5290c2..85ad487b1f8a233717765d15254cadfab8df6750 100644
--- a/Source/core/inspector/InspectorResourceAgent.cpp
+++ b/Source/core/inspector/InspectorResourceAgent.cpp
@@ -91,7 +91,7 @@ static PassRefPtr<JSONObject> buildObjectForHeaders(const HTTPHeaderMap& headers
return headersObject;
}
-class InspectorThreadableLoaderClient : public ThreadableLoaderClient {
+class InspectorThreadableLoaderClient FINAL : public ThreadableLoaderClient {
WTF_MAKE_NONCOPYABLE(InspectorThreadableLoaderClient);
public:
InspectorThreadableLoaderClient(PassRefPtr<LoadResourceForFrontendCallback> callback)
@@ -100,7 +100,7 @@ public:
virtual ~InspectorThreadableLoaderClient() { }
- virtual void didReceiveResponse(unsigned long identifier, const ResourceResponse& response)
+ virtual void didReceiveResponse(unsigned long identifier, const ResourceResponse& response) OVERRIDE
{
WTF::TextEncoding textEncoding(response.textEncodingName());
bool useDetector = false;
@@ -113,7 +113,7 @@ public:
m_responseHeaders = response.httpHeaderFields();
}
- virtual void didReceiveData(const char* data, int dataLength)
+ virtual void didReceiveData(const char* data, int dataLength) OVERRIDE
{
if (!dataLength)
return;
@@ -124,7 +124,7 @@ public:
m_responseText = m_responseText.concatenateWith(m_decoder->decode(data, dataLength));
}
- virtual void didFinishLoading(unsigned long /*identifier*/, double /*finishTime*/)
+ virtual void didFinishLoading(unsigned long /*identifier*/, double /*finishTime*/) OVERRIDE
{
if (m_decoder)
m_responseText = m_responseText.concatenateWith(m_decoder->flush());
@@ -132,13 +132,13 @@ public:
dispose();
}
- virtual void didFail(const ResourceError&)
+ virtual void didFail(const ResourceError&) OVERRIDE
{
m_callback->sendFailure("Loading resource for inspector failed");
dispose();
}
- virtual void didFailRedirectCheck()
+ virtual void didFailRedirectCheck() OVERRIDE
{
m_callback->sendFailure("Loading resource for inspector failed redirect check");
dispose();
« no previous file with comments | « Source/core/inspector/InspectorResourceAgent.h ('k') | Source/core/inspector/InspectorRuntimeAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698