Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: Source/core/inspector/InspectorDatabaseAgent.cpp

Issue 135703002: Update inspector classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: No change under web/ Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDatabaseAgent.h ('k') | Source/core/inspector/InspectorDebuggerAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDatabaseAgent.cpp
diff --git a/Source/core/inspector/InspectorDatabaseAgent.cpp b/Source/core/inspector/InspectorDatabaseAgent.cpp
index 11960dfe0cf668e8b47c548b5725750c35cff6d4..b52981f03dff39d12870abce6587140bfd7f4272 100644
--- a/Source/core/inspector/InspectorDatabaseAgent.cpp
+++ b/Source/core/inspector/InspectorDatabaseAgent.cpp
@@ -68,7 +68,7 @@ void reportTransactionFailed(ExecuteSQLCallback* requestCallback, SQLError* erro
requestCallback->sendSuccess(0, 0, errorObject.release());
}
-class StatementCallback : public SQLStatementCallback {
+class StatementCallback FINAL : public SQLStatementCallback {
public:
static PassOwnPtr<StatementCallback> create(PassRefPtr<ExecuteSQLCallback> requestCallback)
{
@@ -77,7 +77,7 @@ public:
virtual ~StatementCallback() { }
- virtual bool handleEvent(SQLTransaction*, SQLResultSet* resultSet)
+ virtual bool handleEvent(SQLTransaction*, SQLResultSet* resultSet) OVERRIDE
{
SQLResultSetRowList* rowList = resultSet->rows();
@@ -106,7 +106,7 @@ private:
RefPtr<ExecuteSQLCallback> m_requestCallback;
};
-class StatementErrorCallback : public SQLStatementErrorCallback {
+class StatementErrorCallback FINAL : public SQLStatementErrorCallback {
public:
static PassOwnPtr<StatementErrorCallback> create(PassRefPtr<ExecuteSQLCallback> requestCallback)
{
@@ -115,7 +115,7 @@ public:
virtual ~StatementErrorCallback() { }
- virtual bool handleEvent(SQLTransaction*, SQLError* error)
+ virtual bool handleEvent(SQLTransaction*, SQLError* error) OVERRIDE
{
reportTransactionFailed(m_requestCallback.get(), error);
return true;
@@ -127,7 +127,7 @@ private:
RefPtr<ExecuteSQLCallback> m_requestCallback;
};
-class TransactionCallback : public SQLTransactionCallback {
+class TransactionCallback FINAL : public SQLTransactionCallback {
public:
static PassOwnPtr<TransactionCallback> create(const String& sqlStatement, PassRefPtr<ExecuteSQLCallback> requestCallback)
{
@@ -136,7 +136,7 @@ public:
virtual ~TransactionCallback() { }
- virtual bool handleEvent(SQLTransaction* transaction)
+ virtual bool handleEvent(SQLTransaction* transaction) OVERRIDE
{
if (!m_requestCallback->isActive())
return true;
@@ -155,7 +155,7 @@ private:
RefPtr<ExecuteSQLCallback> m_requestCallback;
};
-class TransactionErrorCallback : public SQLTransactionErrorCallback {
+class TransactionErrorCallback FINAL : public SQLTransactionErrorCallback {
public:
static PassOwnPtr<TransactionErrorCallback> create(PassRefPtr<ExecuteSQLCallback> requestCallback)
{
@@ -164,7 +164,7 @@ public:
virtual ~TransactionErrorCallback() { }
- virtual bool handleEvent(SQLError* error)
+ virtual bool handleEvent(SQLError* error) OVERRIDE
{
reportTransactionFailed(m_requestCallback.get(), error);
return true;
@@ -175,7 +175,7 @@ private:
RefPtr<ExecuteSQLCallback> m_requestCallback;
};
-class TransactionSuccessCallback : public VoidCallback {
+class TransactionSuccessCallback FINAL : public VoidCallback {
public:
static PassOwnPtr<TransactionSuccessCallback> create()
{
@@ -184,7 +184,7 @@ public:
virtual ~TransactionSuccessCallback() { }
- virtual void handleEvent() { }
+ virtual void handleEvent() OVERRIDE { }
private:
TransactionSuccessCallback() { }
« no previous file with comments | « Source/core/inspector/InspectorDatabaseAgent.h ('k') | Source/core/inspector/InspectorDebuggerAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698