Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1357023005: Use RandBytes instead of rand_s for pipe names. (Closed)

Created:
5 years, 3 months ago by Will Harris
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use RandBytes instead of rand_s for pipe names. BUG=534449, 379218 Committed: https://crrev.com/cb35f4e7250d6f4ee65e283bd2d13dc7c231c921 Cr-Commit-Position: refs/heads/master@{#350193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M base/sync_socket_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Will Harris
c.f. similar change in crrev.com/1342303003
5 years, 3 months ago (2015-09-21 18:23:43 UTC) #2
rvargas (doing something else)
This change lgtm. Why RandBytes wants to link against a semi-documented function of advapi instead ...
5 years, 3 months ago (2015-09-21 22:29:26 UTC) #3
Will Harris
On 2015/09/21 22:29:26, rvargas (slow to respond) wrote: > This change lgtm. > > Why ...
5 years, 3 months ago (2015-09-22 17:26:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357023005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357023005/1
5 years, 3 months ago (2015-09-22 17:27:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 18:10:27 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cb35f4e7250d6f4ee65e283bd2d13dc7c231c921 Cr-Commit-Position: refs/heads/master@{#350193}
5 years, 3 months ago (2015-09-22 18:44:14 UTC) #8
DaleCurtis
5 years, 3 months ago (2015-09-22 18:46:12 UTC) #10
Message was sent while issue was closed.
Thanks for fixing this! I was following along on the bug and planned to snag
this one later today. You beat me too it :)

Powered by Google App Engine
This is Rietveld 408576698