Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1356983003: Set SelectionPaintingWithoutSelectionGaps to stable. (Closed)

Created:
5 years, 3 months ago by wkorman
Modified:
5 years, 3 months ago
Reviewers:
chrishtr
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Set SelectionPaintingWithoutSelectionGaps to stable. BUG=474759 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202662

Patch Set 1 #

Patch Set 2 : Update test expectations and remove obsolete tests. #

Patch Set 3 : More rebaselines. #

Patch Set 4 : One more rebaseline. #

Patch Set 5 : Updated expectations. #

Patch Set 6 : Two more tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -1071 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 9 chunks +151 lines, -26 lines 0 comments Download
D LayoutTests/fast/repaint/block-selection-gap-in-composited-layer.html View 1 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/repaint/block-selection-gap-in-composited-layer-expected.png View 1 Binary file 0 comments Download
D LayoutTests/fast/repaint/selection-gap-absolute-child.html View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/repaint/selection-gap-absolute-child-expected.txt View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/repaint/selection-gap-fixed-child.html View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/repaint/selection-gap-fixed-child-expected.txt View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/repaint/selection-gap-flipped-absolute-child.html View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/repaint/selection-gap-flipped-absolute-child-expected.txt View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/repaint/selection-gap-flipped-fixed-child.html View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/repaint/selection-gap-flipped-fixed-child-expected.txt View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/repaint/selection-gap-overflow-scroll.html View 1 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/repaint/selection-gap-overflow-scroll-2.html View 1 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/repaint/selection-gap-transformed-absolute-child.html View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/repaint/selection-gap-transformed-absolute-child-expected.txt View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/repaint/selection-gap-transformed-fixed-child.html View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/repaint/selection-gap-transformed-fixed-child-expected.txt View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html View 1 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt View 1 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/paint/invalidation/spv2/selection-gap-absolute-child.html View 1 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/paint/invalidation/spv2/selection-gap-absolute-child-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/paint/invalidation/spv2/selection-gap-fixed-child.html View 1 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/paint/invalidation/spv2/selection-gap-fixed-child-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/paint/invalidation/spv2/selection-gap-flipped-absolute-child.html View 1 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/paint/invalidation/spv2/selection-gap-flipped-absolute-child-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/paint/invalidation/spv2/selection-gap-flipped-fixed-child.html View 1 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/paint/invalidation/spv2/selection-gap-flipped-fixed-child-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/paint/invalidation/spv2/selection-gap-transformed-absolute-child.html View 1 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/paint/invalidation/spv2/selection-gap-transformed-absolute-child-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/paint/invalidation/spv2/selection-gap-transformed-fixed-child.html View 1 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/paint/invalidation/spv2/selection-gap-transformed-fixed-child-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/platform/android/fast/repaint/block-selection-gap-in-composited-layer-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/android/fast/repaint/selection-gap-absolute-child-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/android/fast/repaint/selection-gap-fixed-child-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/android/fast/repaint/selection-gap-flipped-absolute-child-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/android/fast/repaint/selection-gap-flipped-fixed-child-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/android/fast/repaint/selection-gap-transformed-absolute-child-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/android/fast/repaint/selection-gap-transformed-fixed-child-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/android/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/fast/repaint/block-selection-gap-in-composited-layer-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/linux/fast/repaint/selection-gap-overflow-scroll-2-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/linux/fast/repaint/selection-gap-overflow-scroll-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/linux/paint/invalidation/spv2/selection-gap-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/paint/invalidation/spv2/selection-gap-fixed-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/paint/invalidation/spv2/selection-gap-flipped-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/paint/invalidation/spv2/selection-gap-flipped-fixed-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/paint/invalidation/spv2/selection-gap-transformed-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/paint/invalidation/spv2/selection-gap-transformed-fixed-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac-lion/paint/invalidation/spv2/selection-gap-transformed-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac-lion/paint/invalidation/spv2/selection-gap-transformed-fixed-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac-mavericks/paint/invalidation/spv2/selection-gap-transformed-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac-mavericks/paint/invalidation/spv2/selection-gap-transformed-fixed-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/paint/invalidation/spv2/selection-gap-transformed-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/paint/invalidation/spv2/selection-gap-transformed-fixed-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/mac/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/paint/invalidation/spv2/selection-gap-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/paint/invalidation/spv2/selection-gap-fixed-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/paint/invalidation/spv2/selection-gap-flipped-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/paint/invalidation/spv2/selection-gap-flipped-fixed-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/paint/invalidation/spv2/selection-gap-transformed-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/paint/invalidation/spv2/selection-gap-transformed-fixed-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/repaint/block-selection-gap-in-composited-layer-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/repaint/selection-gap-overflow-scroll-2-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/repaint/selection-gap-overflow-scroll-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/win-xp/paint/invalidation/spv2/selection-gap-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/paint/invalidation/spv2/selection-gap-fixed-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/paint/invalidation/spv2/selection-gap-flipped-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/paint/invalidation/spv2/selection-gap-flipped-fixed-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/paint/invalidation/spv2/selection-gap-transformed-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/paint/invalidation/spv2/selection-gap-transformed-fixed-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/block-selection-gap-in-composited-layer-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/win/fast/repaint/selection-gap-overflow-scroll-2-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/win/fast/repaint/selection-gap-overflow-scroll-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/win/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/paint/invalidation/spv2/selection-gap-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/paint/invalidation/spv2/selection-gap-fixed-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/paint/invalidation/spv2/selection-gap-flipped-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/paint/invalidation/spv2/selection-gap-flipped-fixed-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/paint/invalidation/spv2/selection-gap-transformed-absolute-child-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/paint/invalidation/spv2/selection-gap-transformed-fixed-child-expected.png View 1 Binary file 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (17 generated)
wkorman
Sending while waiting for other changes to go in. Presuming I sort out whatever test ...
5 years, 3 months ago (2015-09-18 23:03:29 UTC) #2
chrishtr
lgtm
5 years, 3 months ago (2015-09-18 23:04:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356983003/1
5 years, 3 months ago (2015-09-18 23:04:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/109665)
5 years, 3 months ago (2015-09-19 00:31:29 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356983003/20001
5 years, 3 months ago (2015-09-22 20:49:26 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/110756)
5 years, 3 months ago (2015-09-22 21:43:43 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356983003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356983003/40001
5 years, 3 months ago (2015-09-22 22:25:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356983003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356983003/60001
5 years, 3 months ago (2015-09-22 23:45:34 UTC) #19
chrishtr
lgtm
5 years, 3 months ago (2015-09-22 23:46:54 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/102727)
5 years, 3 months ago (2015-09-23 00:07:42 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356983003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356983003/80001
5 years, 3 months ago (2015-09-23 00:41:00 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/117059)
5 years, 3 months ago (2015-09-23 01:27:54 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356983003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356983003/100001
5 years, 3 months ago (2015-09-23 01:35:09 UTC) #30
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 05:14:36 UTC) #31
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202662

Powered by Google App Engine
This is Rietveld 408576698