components/cronet/android/cronet_url_request_context_adapter.cc - Issue 1356933002: make ProxyService::CreateSystemProxyConfigService return scoped_ptrs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/cronet_url_request_context_adapter.cc

Issue 1356933002: make ProxyService::CreateSystemProxyConfigService return scoped_ptrs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: small ios fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/proxy_service_factory.cc ('K') | « chromecast/browser/url_request_context_factory.cc ('k') | components/cronet/android/url_request_context_adapter.cc » ('j') | net/proxy/proxy_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/cronet_url_request_context_adapter.cc

diff --git a/components/cronet/android/cronet_url_request_context_adapter.cc b/components/cronet/android/cronet_url_request_context_adapter.cc

index c1008498cb223ed398ca15203479bf8005a80ed3..d5097e5a7ba72278f76eb3493a6308239876bdf6 100644

--- a/components/cronet/android/cronet_url_request_context_adapter.cc

+++ b/components/cronet/android/cronet_url_request_context_adapter.cc

@@ -147,8 +147,8 @@ void CronetURLRequestContextAdapter::InitRequestContextOnMainThread(

jobject jcaller) {

base::android::ScopedJavaGlobalRef<jobject> jcaller_ref;

jcaller_ref.Reset(env, jcaller);

- proxy_config_service_.reset(net::ProxyService::CreateSystemProxyConfigService(

- GetNetworkTaskRunner(), nullptr));

+ proxy_config_service_ = net::ProxyService::CreateSystemProxyConfigService(

+ GetNetworkTaskRunner(), nullptr);

GetNetworkTaskRunner()->PostTask(

FROM_HERE,

base::Bind(&CronetURLRequestContextAdapter::InitializeOnNetworkThread,