android_webview/browser/aw_browser_context.cc - Issue 1356933002: make ProxyService::CreateSystemProxyConfigService return scoped_ptrs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_browser_context.cc

Issue 1356933002: make ProxyService::CreateSystemProxyConfigService return scoped_ptrs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: small ios fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/aw_browser_context.cc

diff --git a/android_webview/browser/aw_browser_context.cc b/android_webview/browser/aw_browser_context.cc

index 70f4ccbb40e06dd23e9b3926f43a886725f2d004..2c4db8188950aa5dfb8b2838bbd9fa6c342b8992 100644

--- a/android_webview/browser/aw_browser_context.cc

+++ b/android_webview/browser/aw_browser_context.cc

@@ -68,7 +68,7 @@ net::ProxyConfigService* CreateProxyConfigService() {

static_cast<net::ProxyConfigServiceAndroid*>(

net::ProxyService::CreateSystemProxyConfigService(

BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO),

- nullptr /* Ignored on Android */ ));

+ nullptr /* Ignored on Android */ ).release());

config_service->set_exclude_pac_url(true);

return config_service;

}

« no previous file with comments | « no previous file | android_webview/browser/net/aw_url_request_context_getter.cc » ('j') | chrome/browser/net/proxy_service_factory.cc » ('J')