Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: remoting/base/url_request_context_getter.cc

Issue 1356933002: make ProxyService::CreateSystemProxyConfigService return scoped_ptrs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: need static cast Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/base/url_request_context_getter.cc
diff --git a/remoting/base/url_request_context_getter.cc b/remoting/base/url_request_context_getter.cc
index b527481943dfdc860a8681bd2b56b6639fb35b10..7906f616fe54502633c6a957174976f57bbdfaaf 100644
--- a/remoting/base/url_request_context_getter.cc
+++ b/remoting/base/url_request_context_getter.cc
@@ -17,8 +17,8 @@ URLRequestContextGetter::URLRequestContextGetter(
scoped_refptr<base::SingleThreadTaskRunner> file_task_runner)
: network_task_runner_(network_task_runner),
file_task_runner_(file_task_runner) {
- proxy_config_service_.reset(net::ProxyService::CreateSystemProxyConfigService(
- network_task_runner_, file_task_runner));
+ proxy_config_service_ = net::ProxyService::CreateSystemProxyConfigService(
+ network_task_runner_, file_task_runner);
mmenke 2015/09/21 21:34:51 nit: While you're here, remove the underscore at
mmenke 2015/09/21 21:34:51 nit: Can you just put this in an initializer list
Charlie Harrison 2015/09/22 18:00:28 Done.
}
net::URLRequestContext* URLRequestContextGetter::GetURLRequestContext() {

Powered by Google App Engine
This is Rietveld 408576698