net/proxy/proxy_service_v8.h - Issue 1356933002: make ProxyService::CreateSystemProxyConfigService return scoped_ptrs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_service_v8.h

Issue 1356933002: make ProxyService::CreateSystemProxyConfigService return scoped_ptrs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: need static cast Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_service_v8.h

diff --git a/net/proxy/proxy_service_v8.h b/net/proxy/proxy_service_v8.h

index 5341afe42d6de259d548c17390fe100a03fd2f11..88e7fcc0716cfa5aaff88d969af220fcafa298db 100644

--- a/net/proxy/proxy_service_v8.h

+++ b/net/proxy/proxy_service_v8.h

@@ -20,7 +20,7 @@ class ProxyScriptFetcher;

class ProxyService;

// Creates a proxy service that polls |proxy_config_service| to notice when

-// the proxy settings change. We take ownership of |proxy_config_service|.

+// the proxy settings change.

// |proxy_script_fetcher| specifies the dependency to use for downloading

// any PAC scripts. The resulting ProxyService will take ownership of it.

@@ -38,7 +38,7 @@ class ProxyService;

// # other V8's running in the process must use v8::Locker.

// ##########################################################################

NET_EXPORT scoped_ptr<ProxyService> CreateProxyServiceUsingV8ProxyResolver(

- ProxyConfigService* proxy_config_service,

+ scoped_ptr<ProxyConfigService> proxy_config_service,

ProxyScriptFetcher* proxy_script_fetcher,

scoped_ptr<DhcpProxyScriptFetcher> dhcp_proxy_script_fetcher,

HostResolver* host_resolver,

« no previous file with comments | « net/proxy/proxy_service_unittest.cc ('k') | net/proxy/proxy_service_v8.cc » ('j') | net/url_request/url_request_context_builder.cc » ('J')