make ProxyService::CreateSystemProxyConfigService return scoped_ptrs

ios/chrome/browser/net/proxy_service_factory.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/net/proxy_service_factory.h"
 
 #include "components/proxy_config/pref_proxy_config_tracker_impl.h"
 #include "ios/web/public/web_thread.h"
 #include "net/proxy/proxy_config_service.h"
 #include "net/proxy/proxy_service.h"
@@ skipping 27 matching lines @@
   return make_scoped_ptr(new PrefProxyConfigTrackerImpl(
       local_state_prefs,
       web::WebThread::GetTaskRunnerForThread(web::WebThread::IO)));
 }
 
 // static
 scoped_ptr<net::ProxyService> ProxyServiceFactory::CreateProxyService(
     net::NetLog* net_log,
     net::URLRequestContext* context,
     net::NetworkDelegate* network_delegate,
     net::ProxyConfigService* proxy_config_service,

[Randy Smith (Not in Mondays), 2015/09/18 20:14:55]

Did you look at the call tree leading into this argument?  How hard would it be
to make this argument a scoped_ptr<>?

[Charlie Harrison, 2015/09/21 16:47:04]

Actually I think this won't be hard. Will do this.

     bool quick_check_enabled) {
   DCHECK_CURRENTLY_ON_WEB_THREAD(web::WebThread::IO);
   scoped_ptr<net::ProxyService> proxy_service(
-      net::ProxyService::CreateUsingSystemProxyResolver(proxy_config_service, 0,
-                                                        net_log));
+      net::ProxyService::CreateUsingSystemProxyResolver(
+          make_scoped_ptr(proxy_config_service), 0, net_log));
   proxy_service->set_quick_check_enabled(quick_check_enabled);
   return proxy_service.Pass();
 }
 
 }  // namespace ios