Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: Source/core/rendering/compositing/RenderLayerCompositor.cpp

Issue 135693003: Defer starting of animations until after compositing update (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Reland after fixing flaky tests. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/compositing/RenderLayerCompositor.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/compositing/RenderLayerCompositor.cpp
diff --git a/Source/core/rendering/compositing/RenderLayerCompositor.cpp b/Source/core/rendering/compositing/RenderLayerCompositor.cpp
index b41e690d771a4e3cfa654d666a2c531d24db9dd8..1a941e9b7e3c8d58d46034ba5a7e6bac26a8f959 100644
--- a/Source/core/rendering/compositing/RenderLayerCompositor.cpp
+++ b/Source/core/rendering/compositing/RenderLayerCompositor.cpp
@@ -401,8 +401,18 @@ void RenderLayerCompositor::updateCompositingLayers()
return;
lifecycle().advanceTo(DocumentLifecycle::InCompositingUpdate);
- DocumentLifecycle::Scope lifecycleScope(lifecycle(), DocumentLifecycle::CompositingClean);
+ updateCompositingLayersInternal();
+
+ lifecycle().advanceTo(DocumentLifecycle::CompositingClean);
+
+ DocumentAnimations::startPendingAnimations(m_renderView->document());
+ DocumentAnimations::dispatchAnimationEventsAsync(m_renderView->document());
+ ASSERT(m_renderView->document().lifecycle().state() == DocumentLifecycle::CompositingClean);
+}
+
+void RenderLayerCompositor::updateCompositingLayersInternal()
+{
if (isMainFrame() && m_renderView->frameView())
finishCompositingUpdateForFrameTree(&m_renderView->frameView()->frame());
« no previous file with comments | « Source/core/rendering/compositing/RenderLayerCompositor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698