Source/core/page/PageAnimator.cpp - Issue 135693003: Defer starting of animations until after compositing update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/PageAnimator.cpp

Issue 135693003: Defer starting of animations until after compositing update (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Reland after fixing flaky tests. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/PageAnimator.cpp

diff --git a/Source/core/page/PageAnimator.cpp b/Source/core/page/PageAnimator.cpp

index 9e3c481193216d8ca058e4ac3af0612393284bf9..c0f42bb69d9dc9cec56d255ebfbf0551a4710146 100644

--- a/Source/core/page/PageAnimator.cpp

+++ b/Source/core/page/PageAnimator.cpp

@@ -25,7 +25,9 @@ void PageAnimator::serviceScriptedAnimations(double monotonicAnimationStartTime)

for (RefPtr<Frame> frame = m_page->mainFrame(); frame; frame = frame->tree().traverseNext()) {

frame->view()->serviceScrollAnimations();

- DocumentAnimations::serviceOnAnimationFrame(*frame->document(), monotonicAnimationStartTime);

+ DocumentAnimations::updateAnimationTimingForAnimationFrame(*frame->document(), monotonicAnimationStartTime);

+ // FIXME: animation event dispatch should move to the ScriptedAnimationController

+ DocumentAnimations::dispatchAnimationEvents(*frame->document());

}

Vector<RefPtr<Document> > documents;