Defer starting of animations until after compositing update

Source/core/animation/DocumentAnimations.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 23 matching lines @@
 #include "CSSPropertyNames.h"
 
 namespace WebCore {
 
 class Document;
 class FrameView;
 class Node;
 
 class DocumentAnimations  {
 public:
-    static void serviceOnAnimationFrame(Document&, double monotonicAnimationStartTime);
+    static void serviceOnFrameStart(Document&, double monotonicAnimationStartTime);

[abarth-chromium, 2014/02/20 17:52:00]

Can we rename this function to indicate what it does?  It's not possible to tell
from the name what this function does.

[dstockwell, 2014/02/24 06:03:25]

Done. I split and renamed the functions of DocumentAnimations.

     static void serviceBeforeGetComputedStyle(Node&, CSSPropertyID);
-    static void serviceAfterStyleRecalc(Document&);
+
+    class ServiceOnFrameEndScope {

[abarth-chromium, 2014/02/20 17:52:00]

This is a wacky pattern for calling a function.  Why not just call the function?

[dstockwell, 2014/02/20 18:22:01]

Isn't this the same pattern as DocumentLifecycle::Scope ?

RenderLayerCompositor::updateCompositingLayers has multiple points of return,
this needs to be called at the end.

+        WTF_MAKE_NONCOPYABLE(ServiceOnFrameEndScope);
+    public:
+        ServiceOnFrameEndScope(Document& document)
+            : m_document(document)
+        {
+        }
+        ~ServiceOnFrameEndScope()
+        {
+            DocumentAnimations::serviceOnFrameEnd(m_document);
+        }
+
+    private:
+        Document& m_document;
+    };
 
 private:
     DocumentAnimations() { }
+    static void serviceOnFrameEnd(Document&);
 };
 
 } // namespace
 
 #endif