Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135683007: Modify service_connector_unitttest to use Service<> (Closed)

Created:
6 years, 10 months ago by DaveMoore
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Modify service_connector_unitttest to use Service<> BUG=None TEST=existing R=darin@chromium.org, darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248596

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add space to separate templates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -35 lines) Patch
M mojo/shell/service_connector_unittest.cc View 1 4 chunks +14 lines, -35 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
DaveMoore
6 years, 10 months ago (2014-02-03 19:25:04 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/135683007/diff/1/mojo/shell/service_connector_unittest.cc File mojo/shell/service_connector_unittest.cc (right): https://codereview.chromium.org/135683007/diff/1/mojo/shell/service_connector_unittest.cc#newcode84 mojo/shell/service_connector_unittest.cc:84: scoped_ptr<ServiceFactory<TestServiceImpl, Context>> test_app_; nit: I think some compilers ...
6 years, 10 months ago (2014-02-03 21:02:16 UTC) #2
DaveMoore
Add space to separate templates
6 years, 10 months ago (2014-02-03 21:04:04 UTC) #3
DaveMoore
The CQ bit was checked by davemoore@chromium.org
6 years, 10 months ago (2014-02-03 21:04:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/135683007/60001
6 years, 10 months ago (2014-02-03 21:05:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 22:32:43 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) check_deps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222473
6 years, 10 months ago (2014-02-03 22:32:43 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:32:47 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:32:53 UTC) #9
DaveMoore
6 years, 10 months ago (2014-02-03 22:35:45 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 manually as r248596 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698