Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/compare_codereview.py

Issue 135683003: Explain empty report in compare_codereview.py. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: reupload Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/compare_codereview.py
diff --git a/tools/compare_codereview.py b/tools/compare_codereview.py
index 16f3a0198d9e12647072ab3b3e96c8e8d9e566a9..ae2909611e4d5f0c142f422b64372d81f79c42e2 100755
--- a/tools/compare_codereview.py
+++ b/tools/compare_codereview.py
@@ -325,12 +325,15 @@ def main(control_url, roll_url, verbosity=1):
# pylint: disable=I0011,R0914,R0912
control = CodeReviewHTMLParser.parse(control_url)
roll = CodeReviewHTMLParser.parse(roll_url)
- if not (control and roll):
+ all_bots = set(control) & set(roll) # Set intersection.
+ if not all_bots:
+ print >> sys.stderr, (
+ 'Error: control %s and roll %s have no common trybots.'
+ % (list(control), list(roll)))
return
control_name = '[control %s]' % control_url.split('/')[-1]
roll_name = '[roll %s]' % roll_url.split('/')[-1]
- all_bots = set(control) & set(roll) # Set intersection.
out = sys.stdout
if verbosity > 0:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698