Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 135683003: Explain empty report in compare_codereview.py. (Closed)

Created:
6 years, 11 months ago by hal.canary
Modified:
6 years, 11 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Explain empty report in compare_codereview.py. Let user know when control and roll have no common trybots, instead of being silent. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13194

Patch Set 1 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M tools/compare_codereview.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hal.canary
6 years, 11 months ago (2014-01-24 15:38:05 UTC) #1
borenet
Can you upload this again? I can't see the diff.
6 years, 11 months ago (2014-01-24 15:41:54 UTC) #2
hal.canary
On 2014/01/24 15:41:54, borenet wrote: > Can you upload this again? I can't see the ...
6 years, 11 months ago (2014-01-27 14:36:47 UTC) #3
borenet
On 2014/01/27 14:36:47, Hal Canary wrote: > On 2014/01/24 15:41:54, borenet wrote: > > Can ...
6 years, 11 months ago (2014-01-27 14:37:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/135683003/60001
6 years, 11 months ago (2014-01-27 15:45:34 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-27 16:34:48 UTC) #6
Message was sent while issue was closed.
Change committed as 13194

Powered by Google App Engine
This is Rietveld 408576698