Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/browser/storage/durable_storage_permission_context.h

Issue 1356813002: Autogrant the durable storage permission to bookmarked origins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments; add tests; disregard unbookmarking Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_STORAGE_DURABLE_STORAGE_PERMISSION_CONTEXT_H_ 5 #ifndef CHROME_BROWSER_STORAGE_DURABLE_STORAGE_PERMISSION_CONTEXT_H_
6 #define CHROME_BROWSER_STORAGE_DURABLE_STORAGE_PERMISSION_CONTEXT_H_ 6 #define CHROME_BROWSER_STORAGE_DURABLE_STORAGE_PERMISSION_CONTEXT_H_
7 7
8 #include <vector>
9
8 #include "chrome/browser/permissions/permission_context_base.h" 10 #include "chrome/browser/permissions/permission_context_base.h"
11 #include "components/bookmarks/browser/bookmark_model.h"
9 12
10 class DurableStoragePermissionContext : public PermissionContextBase { 13 class DurableStoragePermissionContext : public PermissionContextBase {
11 public: 14 public:
12 explicit DurableStoragePermissionContext(Profile* profile); 15 explicit DurableStoragePermissionContext(Profile* profile);
13 ~DurableStoragePermissionContext() override = default; 16 ~DurableStoragePermissionContext() override = default;
14 17
18 void DecidePermission(content::WebContents* web_contents,
jsbell 2015/09/24 22:07:36 Can you add a short comment here w/ explanation of
dgrogan 2015/09/25 20:23:43 Done.
19 const PermissionRequestID& id,
20 const GURL& requesting_origin,
21 const GURL& embedding_origin,
22 bool user_gesture,
23 const BrowserPermissionCallback& callback) override;
15 bool IsRestrictedToSecureOrigins() const override; 24 bool IsRestrictedToSecureOrigins() const override;
16 25
17 private: 26 private:
27 FRIEND_TEST_ALL_PREFIXES(BookmarksOriginTest, Exists);
28 FRIEND_TEST_ALL_PREFIXES(BookmarksOriginTest, DoesntExist);
29
30 static bool IsOriginBookmarked(
31 const std::vector<bookmarks::BookmarkModel::URLAndTitle>& bookmarks,
32 const GURL& origin);
33
18 DISALLOW_COPY_AND_ASSIGN(DurableStoragePermissionContext); 34 DISALLOW_COPY_AND_ASSIGN(DurableStoragePermissionContext);
19 }; 35 };
20 36
21 #endif // CHROME_BROWSER_STORAGE_DURABLE_STORAGE_PERMISSION_CONTEXT_H_ 37 #endif // CHROME_BROWSER_STORAGE_DURABLE_STORAGE_PERMISSION_CONTEXT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698