Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 13568003: History: Fix position of lock/unlock button (Closed)

Created:
7 years, 8 months ago by Sergiu
Modified:
7 years, 8 months ago
Reviewers:
Patrick Dubroy
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

History: Fix position of lock/unlock button The lock/unlock button for the managed controls in the history page has been misplaced by one of the patches. This moves it to somewhere else so it looks fine again. R=dubroy@chromium.org BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192577

Patch Set 1 #

Total comments: 2

Patch Set 2 : Take out width #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M chrome/browser/resources/history/history.css View 1 2 2 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/resources/history/history.html View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergiu
7 years, 8 months ago (2013-04-05 09:38:33 UTC) #1
Patrick Dubroy
https://codereview.chromium.org/13568003/diff/1/chrome/browser/resources/history/history.css File chrome/browser/resources/history/history.css (right): https://codereview.chromium.org/13568003/diff/1/chrome/browser/resources/history/history.css#newcode26 chrome/browser/resources/history/history.css:26: width: 65px; i18n.
7 years, 8 months ago (2013-04-05 09:50:26 UTC) #2
Sergiu
https://codereview.chromium.org/13568003/diff/1/chrome/browser/resources/history/history.css File chrome/browser/resources/history/history.css (right): https://codereview.chromium.org/13568003/diff/1/chrome/browser/resources/history/history.css#newcode26 chrome/browser/resources/history/history.css:26: width: 65px; On 2013/04/05 09:50:26, dubroy wrote: > i18n. ...
7 years, 8 months ago (2013-04-05 12:01:14 UTC) #3
Patrick Dubroy
Makes sense. LGTM.
7 years, 8 months ago (2013-04-05 12:09:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiu@chromium.org/13568003/9001
7 years, 8 months ago (2013-04-05 16:21:48 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 16:24:33 UTC) #6
Message was sent while issue was closed.
Change committed as 192577

Powered by Google App Engine
This is Rietveld 408576698