Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1356793002: Remove on-by-default flag --harmony-object (Closed)

Created:
5 years, 3 months ago by adamk
Modified:
5 years, 3 months ago
Reviewers:
caitp (gmail), rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove on-by-default flag --harmony-object It's been enabled since M45, which is now well into its stable period, with no problems reported. Committed: https://crrev.com/7462e99667b9d8636fa4f3b1c1faf88d3b0bf88d Cr-Commit-Position: refs/heads/master@{#30835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -211 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -2 lines 0 comments Download
D src/harmony-object.js View 1 chunk +0 lines, -56 lines 0 comments Download
M src/v8natives.js View 3 chunks +31 lines, -1 line 0 comments Download
M test/js-perf-test/JSTests.json View 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/es6/object-assign.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/harmony/object-assign.js View 1 chunk +0 lines, -142 lines 0 comments Download
M test/simdjs/SimdJs.json View 1 chunk +0 lines, -1 line 0 comments Download
M test/simdjs/generate.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
adamk
5 years, 3 months ago (2015-09-17 23:41:12 UTC) #2
caitp (gmail)
It's feature-complete, just not as fast as we'd like it to be, so there's no ...
5 years, 3 months ago (2015-09-18 02:35:44 UTC) #3
rossberg
lgtm
5 years, 3 months ago (2015-09-18 05:50:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356793002/1
5 years, 3 months ago (2015-09-18 18:36:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 18:37:49 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 18:38:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7462e99667b9d8636fa4f3b1c1faf88d3b0bf88d
Cr-Commit-Position: refs/heads/master@{#30835}

Powered by Google App Engine
This is Rietveld 408576698