Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1356783002: Stop emitting kSloppyLexical errors when --harmony-sloppy-let is enabled (Closed)

Created:
5 years, 3 months ago by adamk
Modified:
5 years, 3 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stop emitting kSloppyLexical errors when --harmony-sloppy-let is enabled This changes the error message for code like: if (false) let x; from "Block-scoped declarations (let, const, function, class) not yet supported outside strict mode" to "Unexpected identifier" (pointing at |x|). Committed: https://crrev.com/bdf5b39f06ae7af0b7c0972b050d603ed919974a Cr-Commit-Position: refs/heads/master@{#30834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/parser.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/preparser.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 3 months ago (2015-09-17 23:06:23 UTC) #2
Dan Ehrenberg
lgtm
5 years, 3 months ago (2015-09-18 02:25:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356783002/1
5 years, 3 months ago (2015-09-18 18:17:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 18:19:58 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 18:20:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdf5b39f06ae7af0b7c0972b050d603ed919974a
Cr-Commit-Position: refs/heads/master@{#30834}

Powered by Google App Engine
This is Rietveld 408576698