Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: util/win/process_info_test.cc

Issue 1356753004: Use argument escaping function in util/win/process_info_test.cc (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/process_info_test.cc
diff --git a/util/win/process_info_test.cc b/util/win/process_info_test.cc
index 4e881fccf64f4913cdf2196ca4cc52d4d0114e2f..0fe49981d4cb0e808edb1f621c6eea6ba9687e86 100644
--- a/util/win/process_info_test.cc
+++ b/util/win/process_info_test.cc
@@ -124,10 +124,13 @@ void TestOtherProcess(const base::string16& directory_modification) {
.Append(test_executable.BaseName().RemoveFinalExtension().value() +
L"_process_info_test_child.exe")
.value();
- // TODO(scottmg): Command line escaping utility.
- ChildLauncher child(
- child_test_executable,
- started_uuid.ToString16() + L" " + done_uuid.ToString16());
+
+ std::wstring args;
+ AppendCommandLineArgument(started_uuid.ToString16(), &args);
+ args += L" ";
+ AppendCommandLineArgument(done_uuid.ToString16(), &args);
+
+ ChildLauncher child(child_test_executable, args);
child.Start();
// Wait until the test has completed initialization.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698