Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1356723002: Use public_deps for v8_base in GN. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use public_deps for v8_base in GN. The previous code took advantage of the fact that a group's deps are implicitly public, but I'm trying to fix that. This also cleans up some duplicated code between component and non-component builds. Committed: https://crrev.com/cb2c22321f2e62e1e0cb3a5aec6ae289c3c1df6d Cr-Commit-Position: refs/heads/master@{#30820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -43 lines) Patch
M BUILD.gn View 2 chunks +17 lines, -43 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
brettw
5 years, 3 months ago (2015-09-17 20:04:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356723002/1
5 years, 3 months ago (2015-09-17 20:06:00 UTC) #4
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 3 months ago (2015-09-17 20:06:03 UTC) #6
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-17 20:12:18 UTC) #8
brettw
Jochen: still need owners review. Feel free to CQ
5 years, 3 months ago (2015-09-17 22:06:51 UTC) #9
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-18 08:32:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356723002/1
5 years, 3 months ago (2015-09-18 08:32:41 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 09:32:36 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 09:32:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb2c22321f2e62e1e0cb3a5aec6ae289c3c1df6d
Cr-Commit-Position: refs/heads/master@{#30820}

Powered by Google App Engine
This is Rietveld 408576698